fixed up IfcCShapeProfileDef error when values of girth and tchickness are same

xBimTeam / XbimGeometry

XbimGeometry contains the CLR interop libraries and the c++ engine used to compute the 3D geometry of models.

https://xbimteam.github.io/

Other

255 stars 128 forks source link

fixed up IfcCShapeProfileDef error when values of girth and tchickness are same #417

Closed okaharu0795 closed 1 year ago

okaharu0795 commented 1 year ago

I confirmed the unit test was ok. But the combined test has not been done, because I couldn't find Xbim.Essential branch that Xbim.ModelGeometry.Scene develop branch depends on. If you tell me which branch can be used, I'll conduct the test.

andyward commented 1 year ago

Thanks @okaharu0795 ! Could you add a test to cover this? you mentioned you had one. I should then be able to complete

okaharu0795 commented 1 year ago

@andyward I added the unit test, so please confirm and merge it if there is no problem. thank you!!