search

xBimTeam / XbimGeometry

XbimGeometry contains the CLR interop libraries and the c++ engine used to compute the 3D geometry of models.
https://xbimteam.github.io/
Other
255 stars 128 forks source link

Fixed regression in processing IfcEdgeCurve with same EdgeStart and EdgeEnd #425

Open ziyike opened 1 year ago

ziyike commented 1 year ago

see https://standards.buildingsmart.org/IFC/RELEASE/IFC4/ADD2_TC1/HTML/schema/ifctopologyresource/lexical/ifcedge.htm in "Attribute Definitions", for param 2 "EdgeEnd": The same vertex can be used for both EdgeStart and EdgeEnd. This appears to be a regression comparing to older versions of this function (InitAdvancedFaces) which uses XbimEdge to do the trimming and handled this situation. comparing-ifcvalve-using-ifcedgecurve-with-same-start-and-end

andyward commented 1 year ago

Thanks Ziyi!

@SteveLockley can you review check if this has been picked up in the v6 netcore branch?

CCT-Mukund-Thakare commented 7 months ago

@ziyike Have you done local development environment set up for fixing the bug's in xbim ?