xBimTeam / XbimPropertySets

.NET library providing access to standard Property sets and related bSDD Data Dictionary metadata
Other
8 stars 6 forks source link

Updated to .net 8 #8

Closed danielaase1337 closed 8 months ago

danielaase1337 commented 8 months ago

Upgraded the project to .net8. No other changes, than version upgrade and file/assembly verions to 8.0

andyward commented 8 months ago

Hi Daniel - thanks for contributing

Looks like the Azure Pipeline buildfile needs updating too?

Out of interest, why do you need to update to net8 for this simple library? This will make it incompatible for anyone on net6/net7 or netframework. I guess there may be reasons, but we should really multi-target frameworks so that consumers on older runtimes can use this project. If you update we can push through.

danielaase1337 commented 8 months ago

At first I thought I needed an updated version to get rid of some extra files in connection with use in Revit 2025.

Checked the dependencies a little more closely, and see that there won't be a problem using the .net6 version.

At closer look, just skip the PR and keep it.

andyward commented 8 months ago

We've seen issues with clashing versions of things like Microsoft.Extensions.Logging.Abstractions from other Revit addins before. Will be updating to Revit 2025 soon so can report back if we have issues with our addins