Update unweighted temporal averages to not require bounds

xCDAT / xcdat

An extension of xarray for climate data analysis on structured grids.

https://xcdat.readthedocs.io/en/latest/

Apache License 2.0

101 stars 11 forks source link

Update unweighted temporal averages to not require bounds #579

Closed tomvothecoder closed 6 months ago

tomvothecoder commented 7 months ago

Description

Closed #437

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] My changes generate no new warnings
[x] Any dependent changes have been merged and published in downstream modules

If applicable:

[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass with my changes (locally and CI/CD build)
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have noted that this is a breaking change for a major release (fix or feature that would cause existing functionality to not work as expected)

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (6238148) 100.00% compared to head (4026035) 100.00%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #579 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 15 15 Lines 1602 1602 ========================================= Hits 1602 1602 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tomvothecoder commented 7 months ago

Hey @pochedls, this simple PR is ready for review whenever you're free. Unit tests are still passing and the script you pasted in #437 works on my end.

tomvothecoder commented 6 months ago

@pochedls No problem, there was no rush here. Thanks for the review!