Closed mgrover1 closed 6 months ago
Thank you for your review! We will fix the documentation here (and ensure docs are up-to-date in general). The daily dataset does not have bounds, which can be added on open (or after open with ds_hourly = ds_hourly.bounds.add_missing_bounds(["T"])
):
ds_hourly = xcdat.open_dataset(filepath2, chunks={"time": "auto"}, add_bounds=["T"])
xCDAT used to add the bounds automatically, but we decided that a user should make this decision.
This is now resolved in #623
I also checked if this issue was present in the other temporal averaging notebook, but it only uses the monthly file that already has bounds.
What happened?
I tried to run through and reproduce the "Calculating Climatology and Departures from Time Series Data" example included in the documentation, but ran into a bounds error.
What did you expect to happen? Are there are possible answers you came across?
I expected to be able to full execute the "Calculating Climatology and Departures from Time Series Data" example, specifically the "Daily Climatology" portion.
Minimal Complete Verifiable Example (MVCE)
Relevant log output
Anything else we need to know?
This is related to the JORS review
Environment
INSTALLED VERSIONS
commit: None python: 3.12.2 | packaged by conda-forge | (main, Feb 16 2024, 20:54:21) [Clang 16.0.6 ] python-bits: 64 OS: Darwin OS-release: 23.4.0 machine: arm64 processor: arm byteorder: little LC_ALL: None LANG: en_US.UTF-8 LOCALE: ('en_US', 'UTF-8') libhdf5: 1.14.3 libnetcdf: 4.9.2
xarray: 2024.2.0 pandas: 2.2.1 numpy: 1.26.4 scipy: 1.12.0 netCDF4: 1.6.5 pydap: None h5netcdf: None h5py: None Nio: None zarr: None cftime: 1.6.3 nc_time_axis: None iris: None bottleneck: None dask: 2024.3.0 distributed: 2024.3.0 matplotlib: 3.8.3 cartopy: None seaborn: None numbagg: None fsspec: 2024.3.0 cupy: None pint: None sparse: 0.15.1 flox: None numpy_groupies: None setuptools: 69.2.0 pip: 24.0 conda: None pytest: None mypy: None IPython: 8.22.2 sphinx: None