xCDAT / xcdat

An extension of xarray for climate data analysis on structured grids.
https://xcdat.readthedocs.io/en/latest/
Apache License 2.0
101 stars 11 forks source link

[PR]: Regridding nan update (dask part only) #634

Closed lee1043 closed 3 months ago

lee1043 commented 3 months ago

Description

To fast track issue resolve for #615, a part of PR #613 is applied in this PR which is applying .values instead of .data for dask case following changes made by @tomvothecoder and @jasonb5

Checklist

If applicable:

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (5de4d7f) to head (8c18727).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #634 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 15 15 Lines 1588 1588 ========================================= Hits 1588 1588 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lee1043 commented 3 months ago

@tomvothecoder @jasonb5 sorry for the duplicating, but as some of my PMP workflow is highly influenced by the issue #615, I wanted repair for that part to be fast tracked, because I guess the new issue found in PR #613 could delay the merging of the PR than anticipated.

tomvothecoder commented 3 months ago

Thanks @lee1043. I am giving us another week so that @jasonb5 can try to get PR #613 done. If it's not done by then, we can merge this PR and move forward with releasing v0.7.0.

tomvothecoder commented 3 months ago

I'll go ahead and merge this.

lee1043 commented 3 months ago

@tomvothecoder @jasonb5 thanks!