[PR] time type conversion to timedelta if timedelta64 is given

lee1043 commented 4 weeks ago

Description

make sure time diff type is timedelta: in case it was timedelta64 convert it, so following .seconds line could run without error

Closes #659

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] My changes generate no new warnings
[x] Any dependent changes have been merged and published in downstream modules

If applicable:

[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass with my changes (locally and CI/CD build)
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have noted that this is a breaking change for a major release (fix or feature that would cause existing functionality to not work as expected)

codecov[bot] commented 4 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (9ad91a0) to head (189e526).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #660 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 15 15 Lines 1542 1544 +2 ========================================= + Hits 1542 1544 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tomvothecoder commented 3 weeks ago

I pushed commit https://github.com/xCDAT/xcdat/pull/660/commits/c6b314a1c7e33df200a3bba2bd0e73ae0748acad to add test coverage for the new code. This PR should be good to go.

lee1043 commented 3 weeks ago

@tomvothecoder thanks for the addition.

I am merging this PR.

xCDAT / xcdat