search

xCollateral / VulkanMod

Vulkan renderer mod for Minecraft.
GNU Lesser General Public License v3.0
1.59k stars 181 forks source link

[Feature Request] Support for dynamic lighting #515

Open Danszerlied opened 1 month ago

Danszerlied commented 1 month ago

Describe the request

It'd be very cool if Vulkan mod natively integrates dynamic handheld lighting, as no such mods are compatible with Vulkan mod atm (lambdynlights or ryoamiclights are incompatible)

Felix14-v2 commented 1 month ago

These mods may get support after the 0.5.0 release. You can already find the testing build with FRAPI support in VulkanMod Discord.

NXTler commented 1 month ago

Dynamic light will probably never be implemented into VulkanMod directly, as it can be easily done externally and would only decrease code readability. Lambdynlights and Ryoamiclights developers need to fix the compatibility issue from their side, as far as I know.

NXTler commented 1 month ago

This can be closed.

LambdAurora commented 4 weeks ago

Dynamic light will probably never be implemented into VulkanMod directly, as it can be easily done externally and would only decrease code readability. Lambdynlights and Ryoamiclights developers need to fix the compatibility issue from their side, we can't do anything.

LambDynamicLights uses LevelRender.getLightColor(BlockAndTintGetter, BlockState, BlockPos) as its injection point, and with several versions of similar rendering mods not requiring specific compatibility code anymore, I personally would rather avoid adding yet more fragile injections in my own mod.

Relevant issue on LambDynamicLights' side: LambdAurora/LambDynamicLights#238.