search

xDimGG / node-steamapi

An object-oriented Steam API wrapper for Node.js developers.
https://www.npmjs.com/package/steamapi
181 stars 42 forks source link

Broken promises! #10

Closed BattleSpunk closed 5 years ago

BattleSpunk commented 6 years ago

Hey, In your resolve function, if the ID is already in the resolvecache, it will break on a page refresh as it's not resolving the promise. if (this.resolveCache.has(id)) return this.resolveCache.get(id);

xDimGG commented 5 years ago

Fixed in https://github.com/xDimGG/node-steamapi/commit/ed74b20c61030c17baff5ff5174d7e56070baf24, silly oversight on my end since I was only using await in my tests.