search

xDimGG / node-steamapi

An object-oriented Steam API wrapper for Node.js developers.
https://www.npmjs.com/package/steamapi
181 stars 42 forks source link

Add Keyv caching to allow for cached values to be stored externally and not in memory #29

Closed Ortovoxx closed 1 year ago

Ortovoxx commented 3 years ago

Keyv allows integration with the current Map api used but also provides external storage of cached values in something like Redis or MongoDB.

I can write the integration but didn't know if you think this is a good idea so thought I would check before I wrote it in.

xDimGG commented 1 year ago

I'll definitely have to think about this. I do feel that it's a bit outside of the scope of this project but feel free to give your own opinion. Also, sorry for the 2 year delay. I haven't really had the free time to work on this project.

Ortovoxx commented 1 year ago

No worries mate, might make a PR in the future but ovbiously this would be optional.

xDimGG commented 1 year ago

After thinking about it, I'm in favor of this change. Do you think you could join the Discord server for a quick chat? https://discord.gg/6d698nhnKx. I just have a few questions about Keyv

xDimGG commented 1 year ago

Closing as stale. Feel free to make this PR if you would like.