search

xDimGG / node-steamapi

An object-oriented Steam API wrapper for Node.js developers.
https://www.npmjs.com/package/steamapi
177 stars 43 forks source link

Added completedGamesOnly property for getUserOwnedGames #49

Closed Greenylie closed 4 months ago

Greenylie commented 4 months ago

Hello xDimGG, first of all nice work with this package, the code is well-written and easy to follow, as well as the docs. I had an idea for a project, which just uses completed games, so I decided to contribute to the package itself instead of filtering the results locally. This is my very first contribution, so please feel free to criticize something that doesn't feel right.

Note: I edited every modified link in the relative docs to TODO, so you can just add the new one where it's needed.

xDimGG commented 4 months ago

Thanks for the PR. I appreciate you taking the time to go through the code and change it to make a pull request. However, this kind of parameter seems a bit out of scope for this package IMO. Mind you, my opinion of this package's scope has changed over time. As an example, in versions 1.x.x and 2.x.x, there was a parameter called hide for filtering out deleted/expired servers for getUserServers. While porting the code to V3, I decided to get rid of that parameter because I felt that it was too specific and something that the package's user should do rather than the package. Unfortunately, I just feel that this parameter is too specific and I want to keep the code true to the Steam API (within reason).

Greenylie commented 4 months ago

Thanks for the PR. I appreciate you taking the time to go through the code and change it to make a pull request. However, this kind of parameter seems a bit out of scope for this package IMO. Mind you, my opinion of this package's scope has changed over time. As an example, in versions 1.x.x and 2.x.x, there was a parameter called hide for filtering out deleted/expired servers for getUserServers. While porting the code to V3, I decided to get rid of that parameter because I felt that it was too specific and something that the package's user should do rather than the package. Unfortunately, I just feel that this parameter is too specific and I want to keep the code true to the Steam API (within reason).

No problem! I enjoyed having a look around, I'll stick to the local filtering for my project!