xGinko / AnarchyExploitFixes

Fix exploits on anarchy Minecraft servers
GNU General Public License v3.0
303 stars 55 forks source link

Add Support 1.17.1 #33

Closed Imptovskii closed 2 years ago

Imptovskii commented 3 years ago

Add support for 1.17.1, the plugin itself works, but some functionality of the plugin does not work, due to the specifics of the 1.17.1 update.

moom0o commented 3 years ago

What functionality doesn't work?

Imptovskii commented 3 years ago

From what I have tested the Anti-Boat Fly and the Packet Fly. Too many errors in console

`[15:52:59] [Netty Epoll Server IO #1/ERROR]: [AnarchyExploitFixes] Unhandled exception occured in onPacketReceiving(PacketEvent) for AnarchyExploitFixes java.lang.IllegalStateException: VehicleExitEvent may only be triggered synchronously. at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:612) ~[patched_1.17.1.jar:git-Purpur-1285] at net.minecraft.world.entity.Entity.removePassenger(Entity.java:2632) ~[patched_1.17.1.jar:git-Purpur-1285] at net.minecraft.world.entity.Entity.stopRiding(Entity.java:2546) ~[patched_1.17.1.jar:git-Purpur-1285] at net.minecraft.world.entity.LivingEntity.stopRiding(LivingEntity.java:3484) ~[?:?] at net.minecraft.world.entity.player.Player.stopRiding(Player.java:1162) ~[?:?] at net.minecraft.server.level.ServerPlayer.stopRiding(ServerPlayer.java:1435) ~[?:?] at net.minecraft.server.level.ServerPlayer.stopRiding(ServerPlayer.java:1430) ~[?:?] at com.google.common.collect.ImmutableList.forEach(ImmutableList.java:408) ~[patched_1.17.1.jar:git-Purpur-1285] at net.minecraft.world.entity.Entity.setRemoved(Entity.java:4152) ~[patched_1.17.1.jar:git-Purpur-1285] at net.minecraft.world.entity.Entity.remove(Entity.java:596) ~[patched_1.17.1.jar:git-Purpur-1285] at net.minecraft.world.entity.Entity.discard(Entity.java:578) ~[patched_1.17.1.jar:git-Purpur-1285] at org.bukkit.craftbukkit.v1_17_R1.entity.CraftEntity.remove(CraftEntity.java:664) ~[patched_1.17.1.jar:git-Purpur-1285] at me.moomoo.anarchyexploitfixes.patches.ProtocolLib$3.onPacketReceiving(ProtocolLib.java:90) ~[?:?] at com.comphenix.protocol.injector.SortedPacketListenerList.invokeReceivingListener(SortedPacketListenerList.java:114) ~[?:?] at com.comphenix.protocol.injector.SortedPacketListenerList.invokePacketRecieving(SortedPacketListenerList.java:67) ~[?:?] at com.comphenix.protocol.injector.PacketFilterManager.handlePacket(PacketFilterManager.java:537) ~[?:?] at com.comphenix.protocol.injector.PacketFilterManager.invokePacketRecieving(PacketFilterManager.java:509) ~[?:?] at com.comphenix.protocol.injector.netty.ProtocolInjector.packetReceived(ProtocolInjector.java:360) ~[?:?] at com.comphenix.protocol.injector.netty.ProtocolInjector.onPacketReceiving(ProtocolInjector.java:325) ~[?:?] at com.comphenix.protocol.injector.netty.ChannelInjector.decode(ChannelInjector.java:593) ~[?:?] at io.netty.handler.codec.ByteToMessageDecoder.decodeRemovalReentryProtection(ByteToMessageDecoder.java:507) ~[patched_1.17.1.jar:git-Purpur-1285] at io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:446) ~[patched_1.17.1.jar:git-Purpur-1285] at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:276) ~[patched_1.17.1.jar:git-Purpur-1285] at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379) ~[patched_1.17.1.jar:git-Purpur-1285] at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365) ~[patched_1.17.1.jar:git-Purpur-1285] at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357) ~[patched_1.17.1.jar:git-Purpur-1285] at com.comphenix.protocol.injector.netty.ChannelInjector$2.channelRead(ChannelInjector.java:289) ~[?:?] at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379) ~[patched_1.17.1.jar:git-Purpur-1285] at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365) ~[patched_1.17.1.jar:git-Purpur-1285] at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357) ~[patched_1.17.1.jar:git-Purpur-1285] at io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:324) ~[patched_1.17.1.jar:git-Purpur-1285] at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:296) ~[patched_1.17.1.jar:git-Purpur-1285] at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379) ~[patched_1.17.1.jar:git-Purpur-1285] at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365) ~[patched_1.17.1.jar:git-Purpur-1285] at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357) ~[patched_1.17.1.jar:git-Purpur-1285] at io.netty.handler.timeout.IdleStateHandler.channelRead(IdleStateHandler.java:286) ~[patched_1.17.1.jar:git-Purpur-1285] at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379) ~[patched_1.17.1.jar:git-Purpur-1285] at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365) ~[patched_1.17.1.jar:git-Purpur-1285] at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357) ~[patched_1.17.1.jar:git-Purpur-1285] at io.netty.handler.flush.FlushConsolidationHandler.channelRead(FlushConsolidationHandler.java:152) ~[patched_1.17.1.jar:git-Purpur-1285] at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379) ~[patched_1.17.1.jar:git-Purpur-1285] at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365) ~[patched_1.17.1.jar:git-Purpur-1285] at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357) ~[patched_1.17.1.jar:git-Purpur-1285] at io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1410) ~[patched_1.17.1.jar:git-Purpur-1285] at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379) ~[patched_1.17.1.jar:git-Purpur-1285] at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365) ~[patched_1.17.1.jar:git-Purpur-1285] at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:919) ~[patched_1.17.1.jar:git-Purpur-1285] at io.netty.channel.epoll.AbstractEpollStreamChannel$EpollStreamUnsafe.epollInReady(AbstractEpollStreamChannel.java:795) ~[patched_1.17.1.jar:git-Purpur-1285] at io.netty.channel.epoll.EpollEventLoop.processReady(EpollEventLoop.java:480) ~[patched_1.17.1.jar:git-Purpur-1285] at io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:378) ~[patched_1.17.1.jar:git-Purpur-1285] at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:989) ~[patched_1.17.1.jar:git-Purpur-1285] at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74) ~[patched_1.17.1.jar:git-Purpur-1285] at java.lang.Thread.run(Thread.java:831) [?:?]

net.minecraft.network.protocol.game.PacketPlayInUseEntity@4c568f70[ a=2182 b=net.minecraft.network.protocol.game.PacketPlayInUseEntity$d@74c61f50 c=false ]

[15:52:59] [Server thread/ERROR]: Could not pass event PlayerMoveEvent to AnarchyExploitFixes v1.18.15 java.lang.ArrayIndexOutOfBoundsException: Index 0 out of bounds for length 0 at com.google.common.collect.RegularImmutableList.get(RegularImmutableList.java:60) ~[patched_1.17.1.jar:git-Purpur-1285] at net.minecraft.world.entity.Entity.ejectPassengers(Entity.java:2533) ~[patched_1.17.1.jar:git-Purpur-1285] at org.bukkit.craftbukkit.v1_17_R1.entity.CraftEntity.eject(CraftEntity.java:752) ~[patched_1.17.1.jar:git-Purpur-1285] at me.moomoo.anarchyexploitfixes.patches.GodMode.onMove(GodMode.java:21) ~[?:?] at com.destroystokyo.paper.event.executor.asm.generated.GeneratedEventExecutor259.execute(Unknown Source) ~[?:?] at org.bukkit.plugin.EventExecutor.lambda$create$1(EventExecutor.java:69) ~[patched_1.17.1.jar:git-Purpur-1285] at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:76) ~[patched_1.17.1.jar:git-Purpur-1285] at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70) ~[patched_1.17.1.jar:git-Purpur-1285] at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:624) ~[patched_1.17.1.jar:git-Purpur-1285] at net.minecraft.server.network.ServerGamePacketListenerImpl.handleMoveVehicle(ServerGamePacketListenerImpl.java:693) ~[?:?] at net.minecraft.network.protocol.game.ServerboundMoveVehiclePacket.handle(ServerboundMoveVehiclePacket.java:41) ~[?:?] at net.minecraft.network.protocol.game.ServerboundMoveVehiclePacket.handle(ServerboundMoveVehiclePacket.java:7) ~[?:?] at net.minecraft.network.protocol.PacketUtils.lambda$ensureRunningOnSameThread$1(PacketUtils.java:56) ~[?:?] at net.minecraft.server.TickTask.run(TickTask.java:18) ~[patched_1.17.1.jar:git-Purpur-1285] at net.minecraft.util.thread.BlockableEventLoop.doRunTask(BlockableEventLoop.java:149) ~[?:?] at net.minecraft.util.thread.ReentrantBlockableEventLoop.doRunTask(ReentrantBlockableEventLoop.java:23) ~[?:?] at net.minecraft.server.MinecraftServer.doRunTask(MinecraftServer.java:1422) ~[patched_1.17.1.jar:git-Purpur-1285] at net.minecraft.server.MinecraftServer.shouldRun(MinecraftServer.java:190) ~[patched_1.17.1.jar:git-Purpur-1285] at net.minecraft.util.thread.BlockableEventLoop.pollTask(BlockableEventLoop.java:122) ~[?:?] at net.minecraft.server.MinecraftServer.pollTaskInternal(MinecraftServer.java:1400) ~[patched_1.17.1.jar:git-Purpur-1285] at net.minecraft.server.MinecraftServer.pollTask(MinecraftServer.java:1393) ~[patched_1.17.1.jar:git-Purpur-1285] at net.minecraft.util.thread.BlockableEventLoop.managedBlock(BlockableEventLoop.java:132) ~[?:?] at net.minecraft.server.MinecraftServer.waitUntilNextTick(MinecraftServer.java:1369) ~[patched_1.17.1.jar:git-Purpur-1285] at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1280) ~[patched_1.17.1.jar:git-Purpur-1285] at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:319) ~[patched_1.17.1.jar:git-Purpur-1285] at java.lang.Thread.run(Thread.java:831) [?:?]`

moom0o commented 3 years ago

Update ProtocolLib

Imptovskii commented 3 years ago

Latest version 4.7.0

compieter-gh commented 3 years ago

@Imptovskii Send ur plugin list & server version.

Imptovskii commented 3 years ago

@Imptovskii Send ur plugin list & server version.

image IllegalStack installed temporarily, Anyway, this is a test server

compieter-gh commented 3 years ago

@moom0o isn't this a plugin conflict as it cant pass the inventory event maybe cause its in use by illegalstack? Or an other plugin.

Imptovskii commented 3 years ago

@moom0o isn't this a plugin conflict as it cant pass the inventory event maybe cause its in use by illegalstack? Or an other plugin.

I made a similar build, only on the 1.16.5 version. There is no such problem. A similar problem occurred on non-updated plugins to support 1.17.1

image

Imptovskii commented 3 years ago

https://www.youtube.com/watch?v=UGwDYqXFNUU

compieter-gh commented 3 years ago

Wait you use purpur try to check the issue with paper/tuinity it could be that purpur has some modification that breaks existing behavior with the new update.

compieter-gh commented 3 years ago

Also would be good practice to make sure your running the latest versions with your plugins on 1.17.1

Imptovskii commented 3 years ago

Also would be good practice to make sure your running the latest versions with your plugins on 1.17.1

I made a video where I removed everything from plugins, left only NPC (Latest version with Support 1.17), ProtocolLib and AnarchyExploitFixes. I removed the anti-cheat and it was the same.

Imptovskii commented 3 years ago

Wait you use purpur try to check the issue with paper/tuinity it could be that purpur has some modification that breaks existing behavior with the new update.

Test on Airplane and Tuinity. And nothing has changed

blockswerker commented 2 years ago

I'm getting this error on 1.17.1 with the latest Paper and ProtocolLib.

compieter-gh commented 2 years ago

Am also getting a similar error https://pastebin.com/dUWY74p2

moom0o commented 2 years ago

Found a fix for the VehicleExitEvent error, is there any other errors you are receiving?

moom0o commented 2 years ago

https://github.com/moom0o/AnarchyExploitFixes/releases/tag/1.18.21 Re-open if you have any more issues.

@Imptovskii @blockswerker @ComPieter-1