xGladiate / pe

0 stars 0 forks source link

Add Command cannot parse email with consecutive dots #6

Open xGladiate opened 1 week ago

xGladiate commented 1 week ago

Issue

The email John..Doee@example.com could not be added into the system although the email is valid based on the constraints give.

Steps to reproduce:

  1. Input this line into the command add n/John Doee p/98765432 e/John..Doee@example.com a/311, Clementi Ave 2, #02-25 t/friends t/owesMoney Although the email is valid, based on the error message - which indicates that the use of . is allowed. The contact with this email could not be added into the system. As after inputting this line, an error message would be shown.

image.png

Suggestion

Allow the addition of such input into the system.

nus-se-script commented 1 week ago

Team's Response

Changes

Severity: Low

Response: NotInScope

Justification

Even though this was not included in the error message email format, according to common email specifications, the local part of an email cannot contain consecutive dots unless quoted, which is a very rare occurrence. Hence, in our opinion, Low severity would be more appropriate.

image.png

We believe this is out of scope of the current iteration as the value provided by supporting it will be minimal (as this is a very rare edge case and our product's primary focus is public address management) and the command fails gracefully when they try to do so.

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]