search

xHasKx / luamqtt

luamqtt - Pure-lua MQTT v3.1.1 and v5.0 client
https://xhaskx.github.io/luamqtt/
MIT License
160 stars 42 forks source link

fix(randomseed) do not randomseed from a library #30

Closed Tieske closed 3 years ago

Tieske commented 3 years ago

The random number generator contains application level state and hence should NEVER be seeded from a library. Seeding it is an application level responsibility, always.

xHasKx commented 3 years ago

@Tieske, thanks for the PR. I agree with you. Before accepting PR I'll add a call to math.randomseed() into all tests and examples using auto-generated client ID. It's critical for tests because they can be run in parallel on Travis CI

Tieske commented 3 years ago

where can I find the CI results? no links in this repo.

I tried running them locally, but they failed for me (just hang)

xHasKx commented 3 years ago

CI results are available at the green image "build passing" link at the top of README.md: https://travis-ci.org/xHasKx/luamqtt But I just found that Travis CI is not free anymore for opensource projects. Now I'm trying to create a Docker image to run tests at the https://circleci.com/ So it's slowing down the whole process a lot

Tieske commented 3 years ago

It's still free but you must migrate it

Tieske commented 3 years ago

duh... I looked for the CI badges/links underneath the logo, they were above. My bad.

Tieske commented 3 years ago

It's still free but you must migrate it

maybe not... got a message to select a plan just yet

xHasKx commented 3 years ago

CI results are available at the green image "build passing" link at the top of README.md: https://travis-ci.org/xHasKx/luamqtt But I just found that Travis CI is not free anymore for opensource projects. Now I'm trying to create a Docker image to run tests at the https://circleci.com/ So it's slowing down the whole process a lot

Instead of circleci I decided to move autotests and code coverage report to GitHub Actions, and finally succeed. I'll continue to work on this pull request after holidays