search

xHasKx / luamqtt

luamqtt - Pure-lua MQTT v3.1.1 and v5.0 client
https://xhaskx.github.io/luamqtt/
MIT License
154 stars 41 forks source link

Use git+https protocol instead of git #39

Closed jst-mbs closed 2 years ago

jst-mbs commented 2 years ago

The installation with luarocks doesn't work anymore because the git url is depreciated: https://github.blog/2021-09-01-improving-git-protocol-security-github/.

$ sudo luarocks install luamqtt
Installing https://luarocks.org/luamqtt-3.4.2-2.rockspec
Klone nach 'luamqtt' ...
fatal: Fehler am anderen Ende: 
  The unauthenticated git protocol on port 9418 is no longer supported.
Please see https://github.blog/2021-09-01-improving-git-protocol-security-github/ for more information.

Error: Failed cloning git repository.
Tieske commented 2 years ago

this also requires the rockspec to be renamed to version 3.4.2-3 (revision 2 -> 3, also inside the rockspec this must be updated.)

jst-mbs commented 2 years ago

this also requires the rockspec to be renamed to version 3.4.2-3 (revision 2 -> 3, also inside the rockspec this must be updated.)

Thanks, I've changed that.

xHasKx commented 2 years ago

I've updated the rockspec file on luarocks.org and merged that pull request. Thanks, @jst-mbs, and @Tieske!

I'll also update the test runner script because luabitop package for lua5.1 was affected by the same git+https error

xHasKx commented 2 years ago

I'll also update the test runner script because luabitop package for lua5.1 was affected by the same git+https error

Done in 96de616201b18dddc64634b7a6bc3dcbe49f057d

xHasKx commented 2 years ago

@jst-mbs, @Tieske, do you have an idea how to communicate with luarocks.org team? The buggy rockspec for luabitop module is uploaded by them: https://luarocks.org/modules/luarocks/luabitop

Tieske commented 2 years ago

They fixed it in LuaRocks, have you tried upgrading? it will by default inject "git+https" for anything "git" only. Best way to communicate would be to use github issues, or maybe the Gitter channel