search

xJREB / service-based-antipatterns

A structured collection of service-based antipatterns and bad smells, served by a web application for convenient browsing
https://xjreb.github.io/service-based-antipatterns
MIT License
15 stars 1 forks source link

refactoring color, evidence header, toast #111

Closed mpoqq closed 5 years ago

mpoqq commented 5 years ago

@xJREB I changed the evidence representation to horizontal and I also changed the size of the Toasts a little bit. image Is it more noticeable now?

mpoqq commented 5 years ago

ref #110

xJREB commented 5 years ago

This looks definitely better, but I would not let the evidence bar take up space of the general header. The title should be vertically centered in the petrol color (#10627a). Maybe you can also try to place the evidence bar BELOW the header... 🤔 May look nicer...

xJREB commented 5 years ago

Moreover, if we have the colors.scss file, do we still need all of this?

Vue.use(Vuetify, {
    theme: {
        primary: {base: '#10627a', darken1: '#455066'},
        secondary: '#ffa500',
        accent: '#4395AD',
        error: '#FF5252',
        info: '#4395AD',
        success: '#FFFFFF',
        warning: '#FFC107',
    },
    iconfont: 'md',
});

This would mean, there are still two places to change colors...

mpoqq commented 5 years ago

New version with evidence below the header: image It is not that easy to set the colors in one place because we need to configure vuetify in the script(ts) and we also need the colors in the style (css) part. There are solutions like a 'node-sass-json-importer' but I think this is more overhead than the solution with two places.

xJREB commented 5 years ago

OK, looks much better now. 👍 And I understand the part with the color configuration. Would probably be best to leave it like that.