Witchery Custom Brews are uncraftable

Satvn commented 3 months ago

Was this bug reported before?

[X] No, it was not.

Please provide a link to your crash report or latest.log, if relevant

No response

If you have any, please provide a list of additional mods

No response

Please describe the issue you are experiencing

The custom brews from witchery are completely uncraftable, creating only a NBT:1 glass bottle and consuming a third of the cauldron's fluid, i have tested this on a multiplayer 1.12 pack server and a singleplayer 1.12 pack world and netted the same results, however i also tested this on a custom world running only witchery and its dependencies and this issue was not prevalent

A 1.12 Singleplayer world with failing to craft the extinguishing brew https://youtu.be/EFzcjt6nScg

Whereas in a barebones pack it made it without difficulty 2024-06-20_10 39 15

xJon commented 3 months ago

however i also tested this on a custom world running only witchery and its dependencies and this issue was not prevalent

Can you try also adding Witchery: Companion and testing again?

Satvn commented 3 months ago

however i also tested this on a custom world running only witchery and its dependencies and this issue was not prevalent

Can you try also adding Witchery: Companion and testing again?

The custom pack is running Resurrected, companion (and mixin/1.7.10 witchery as they are dependencies)

xJon commented 3 months ago

Hmm, what about the game log? Did you find any errors in the game log as you tested this?

Satvn commented 3 months ago

I didnt think it did but retested to be sure, the bottling does not produce anything in the logs whatsoever, however i then clicked both a normal bottle and the NBT bottle on an empty cauldron and it spammed my log with crash reports, i then tested the exact same on my witchery pack and it does not do this crash-2024-06-20_11.07.56-server.txt crash-2024-06-20_11.09.08-server.txt

Satvn commented 3 months ago

Based on the crash log, i tested on my test pack adding only Charset crafting and Charsetlib, and the issue is created, I disabled the crafting.cauldron module in the charset config and the issue is resolved

More specifically, the issue is to do with the I:waterBottleSize= config in crafting.cauldrons cfg file, the mod changes it to 250 by default which screws with witchery's potion making it seems, i set the config to I:waterBottleSize=0 (to make it default) and i could make the potion with the module enabled

Satvn commented 3 months ago

Turns out that whilst the Charset issue is real and does error out the cauldron, there is something else that causes the potions to be uncraftable as it is also present in a 1.12 modpack world with charset's cauldron module completely disabled, or the charset crafting mod gone entirely, ive had a play around with taking apart the pack, configs, random mods, but my console produces absolutely nothing, so i have nothing to go off other than cutting out mods at random and hoping the issue goes away, ill likely look over this some more though however currently dont know whats broken

xJon commented 3 months ago

@Satvn

Can you try manually updating to the latest version of Witchery: Companion, change its config (set Disable Fluid Handlers to true) and see if the issue is resolved?
If that still didn't resolve it, have you tried removing all of the Charset mods?

Satvn commented 3 months ago

2024-06-27_00 50 14 2024-06-27_00 58 54

The new config option works perfectly, makes the brews without any issue, and with no charset modification needed

xJon / The-1.12.2-Pack