search

xJon / The-1.7.10-Pack

A Minecraft modpack
https://the-1710-pack.com
51 stars 31 forks source link

Fairy Lights & Morph conflicting with Optifine E7 / Shaders #1990

Open wolflord212312 opened 1 year ago

wolflord212312 commented 1 year ago

Patch here Please Review the code before you install like i did,Fairlights-Patched

all this does i changes how fairy lights does its render as before it did not have the arguments for Fairylights to work without crashing the modpack it also cleans up the code to make it more compact and modern.

wolflord212312 commented 1 year ago

and i did test it game launches fine and had no real issues besides optifine issues that exist with probs some other mods in the pack and really only happen with certain shaders as well shaders are not known for there Mod support lol

wolflord212312 commented 1 year ago

FastCraft seems to negate all improvements from optifine so if you have fascraft + optifine i go without fast craft off 100+ frames toss in fastcraft with optifine and now i got 22 also seems that the morph mod causes your client to get kicked from servers sometimes with a morph model error... But that can be ignored

wolflord212312 commented 1 year ago

Investigating possible fix with morph,If one is not already made i will go ahead and atempt to make one but depends if i can find why it Only (sometimes) causes a fatal error and kicks you from servers with optifine e7

wolflord212312 commented 1 year ago

-Ok so im thinking actually some of these is fastcraft patching some fucking things and optifine trying to patch the same thing leading to weird other mod issues such as the model handler with morph and a issue with magical crops

wolflord212312 commented 1 year ago

Conclusion This fixes you not being able to start the pack with newer versions of optifine for 1.7.10 but does not fix all issues,in Optifine E7 You will get kicked from world/server when anything with the morph mod happens the morph mod needs to be patched to get optifine E7 into a Mostly working order (and it is a kick loop as long as you have optifine E7 installed if you tried to morph easy fix would be remove the animations from the morph mod) But that aint fun So unless someone goes ahead and fixes the morph mod for optifine it is still a faliure but the mod above fixes the biggest issue.

xJon commented 1 year ago

Thank you for the suggesting & looking into this! I understand Optifine E7 has compatibility for shaders, but indeed it has some issues with other mods, as well as with Fastcraft - that is why we suggest to use Optifine D6 mostly.