search

xJonathanLEI / starkli

Starkli (/ˈstɑːrklaɪ/), a ⚡ blazing ⚡ fast ⚡ CLI tool for Starknet powered by 🦀 starknet-rs 🦀
https://book.starkli.rs
Apache License 2.0
164 stars 47 forks source link

fix known account class for braavos #60

Closed 0xcoburn closed 9 months ago

0xcoburn commented 9 months ago

update known account class

xJonathanLEI commented 9 months ago

Thanks for the PR! I'm not sure we should add a AccountVariantType variant for this though? These variants exist only to deal with account classes with different interfaces so that they need to be treated differently when fetching. If the new Braavos class exposes the same interface (as far as our use of it is concerned, of course), we can just add the hash.

I will have to check which is the case though.

xJonathanLEI commented 9 months ago

Branch does not compile.

xJonathanLEI commented 9 months ago

Superseded by https://github.com/xJonathanLEI/starkli/commit/d2c3342266c6a7d21fbe7d7eccc9211514718857.