xJonathanLEI / starknet-rs

Complete Starknet library in Rust™
https://starknet.rs
Apache License 2.0
271 stars 89 forks source link

Add more clippy lint rules #596

Open tcoratger opened 1 month ago

tcoratger commented 1 month ago

In order for the codebase to be more Rust idiomatic and to improve some part/performance, we could enforce more clippy lint rules at a root level.

See for example what is done here:

https://github.com/paradigmxyz/reth/blob/56859b417226b0b799484f4251cfe04c1d848958/Cargo.toml#L113-L186

Generally speaking, there are certain rules that are painful to have or maintain, but some from the list mentioned above are extremely useful to have on a repository to maintain a high level of code quality and maintainability.

aniketpr01 commented 1 month ago

@tcoratger Can i take this

tcoratger commented 1 month ago

@tcoratger Can i take this

Assigned