feat: replace poseidon impl with type-rs

xJonathanLEI / starknet-rs

Complete Starknet library in Rust™

https://starknet.rs

Apache License 2.0

281 stars 96 forks source link

feat: replace poseidon impl with type-rs #630

Closed thetheveloper closed 2 months ago

thetheveloper commented 2 months ago

Closes #608

Removes current Poseidon implementation & replaces with the one implemented in type-rs

thetheveloper commented 2 months ago

@tcoratger the PR is ready for review

ci failed for the same reason the other PRs failed - locally everything was fine, pushing here again it started failing mostly with InvalidNonce or Provider(StarknetError(DuplicateTx)). Could you please take a look if the implementation is in fact correct as all tests are passing locally?

xJonathanLEI commented 2 months ago

Somehow these two tests would always say duplicate tx:

can_execute_eth_transfer_invoke_v1_with_jsonrpc
can_execute_eth_transfer_invoke_v3_with_jsonrpc

It's almost like the sequencer refuses to process those txs and they got stuck.

xJonathanLEI commented 2 months ago

I manually bumped the gas price to use that nonce. Should be good again.