search

xKDR / CRRao.jl

MIT License
35 stars 21 forks source link

CompatHelper: bump compat for Turing to 0.26, (keep existing compat) #121

Closed github-actions[bot] closed 5 months ago

github-actions[bot] commented 1 year ago

This pull request changes the compat entry for the Turing package from 0.23.2, 0.24 to 0.23.2, 0.24, 0.26. This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

sourish-cmi commented 1 year ago

@ayushpatnaikgit @ShouvikGhosh2048 we have a bunch of CompatHelper issues opened for a long time. We should close those now.

ayushpatnaikgit commented 1 year ago

@ShouvikGhosh2048 can you take a look at why this PR is failing CI test?

ShouvikGhosh2048 commented 1 year ago

The error:

ERROR: Unsatisfiable requirements detected for package DynamicPPL [366bfd00]:
 DynamicPPL [366bfd00] log:
 ├─possible versions are: 0.1.0-0.23.0 or uninstalled
 ├─restricted by compatibility requirements with Turing [fce5fe82] to versions: 0.23.0
 │ └─Turing [fce5fe82] log:
 │   ├─possible versions are: 0.5.0-0.26.0 or uninstalled
 │   └─restricted to versions 0.26 by CRRao [49d1be55], leaving only versions 0.26.0
 │     └─CRRao [49d1be55] log:
 │       ├─possible versions are: 0.1.0 or uninstalled
 │       └─CRRao [49d1be55] is fixed to version 0.1.0
 └─restricted by compatibility requirements with AbstractPPL [7a57a42e] to versions: 0.1.0-0.21.3 or uninstalled — no versions left
   └─AbstractPPL [7a57a42e] log:
     ├─possible versions are: 0.1.0-0.6.2 or uninstalled
     └─restricted by julia compatibility requirements to versions: 0.1.0-0.5.2 or uninstalled

Referring to this it seems to occur due to the Julia version? I'm not sure why AbstractPPL is restricted.

sourish-cmi commented 1 year ago

The error:

ERROR: Unsatisfiable requirements detected for package DynamicPPL [366bfd00]:
 DynamicPPL [366bfd00] log:
 ├─possible versions are: 0.1.0-0.23.0 or uninstalled
 ├─restricted by compatibility requirements with Turing [fce5fe82] to versions: 0.23.0
 │ └─Turing [fce5fe82] log:
 │   ├─possible versions are: 0.5.0-0.26.0 or uninstalled
 │   └─restricted to versions 0.26 by CRRao [49d1be55], leaving only versions 0.26.0
 │     └─CRRao [49d1be55] log:
 │       ├─possible versions are: 0.1.0 or uninstalled
 │       └─CRRao [49d1be55] is fixed to version 0.1.0
 └─restricted by compatibility requirements with AbstractPPL [7a57a42e] to versions: 0.1.0-0.21.3 or uninstalled — no versions left
   └─AbstractPPL [7a57a42e] log:
     ├─possible versions are: 0.1.0-0.6.2 or uninstalled
     └─restricted by julia compatibility requirements to versions: 0.1.0-0.5.2 or uninstalled

Referring to this it seems to occur due to the Julia version? I'm not sure why AbstractPPL is restricted.

Oh dear - what do we do now?

ShouvikGhosh2048 commented 1 year ago

https://discourse.julialang.org/t/julia-compatibility-requirement-error/103724/2

sourish-cmi commented 1 year ago

https://discourse.julialang.org/t/julia-compatibility-requirement-error/103724/2

Okay looks like a possible solution.