Closed jishnub closed 1 year ago
Merging #290 (c204a14) into v0.1.1 (f9aa828) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## v0.1.1 #290 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 12 12
Lines 187 200 +13
=========================================
+ Hits 187 200 +13
Impacted Files | Coverage Δ | |
---|---|---|
src/bootstrap.jl | 100.00% <100.00%> (ø) |
... and 2 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Hi @jishnub. Thanks for contributing to improve type stability in the package! We have been planning to overhaul the entire package for improving type stability issues.
@ayushpatnaikgit and I will do a few more speed tests on some other datasets, but I think PR should be good to merge soon
I changed merging branch from main
to v0.1.1
Separating out the type-unstable and the type-stable parts leads to a moderate speed-up and a slight reduction in allocation. Using the example from the docstring of
bootweights
on the main branch, we obtain:This PR
A speedup of
13%