Closed nadiaenh closed 10 months ago
Also, we may name it glm
instead of svyglm
. Just for now, we should avoid the ambiguity.
This PR solves issues #295
Merging #304 (c677962) into 0.3.1 (b5b9b09) will decrease coverage by
12.50%
. Report is 6 commits behind head on 0.3.1. The diff coverage is92.10%
.
@@ Coverage Diff @@
## 0.3.1 #304 +/- ##
============================================
- Coverage 100.00% 87.50% -12.50%
============================================
Files 14 15 +1
Lines 242 272 +30
============================================
- Hits 242 238 -4
- Misses 0 34 +34
Files Changed | Coverage Δ | |
---|---|---|
src/Survey.jl | 100.00% <ø> (ø) |
|
src/quantile.jl | 87.50% <57.14%> (-12.50%) |
:arrow_down: |
src/ratio.jl | 75.00% <70.00%> (-25.00%) |
:arrow_down: |
src/bootstrap.jl | 100.00% <100.00%> (ø) |
|
src/by.jl | 100.00% <100.00%> (ø) |
|
src/jackknife.jl | 100.00% <100.00%> (ø) |
|
src/mean.jl | 100.00% <100.00%> (ø) |
|
src/reg.jl | 100.00% <100.00%> (ø) |
|
src/total.jl | 100.00% <100.00%> (ø) |
glm
from svyglm
?glm
? Doctests were passing because :fix = true
was uncommented in docs/project.toml
this means that all doctests may have incorrect values.
Bunch of doctests were failing. I am unsure why the doctest CI didn't give an error. I'll fix them in PR 314
Building on Ayush's code for GLM:
glm( )
tosvyglm( )
to avoid ambiguity and be consistent with R namingbsrs
Ready to be merged as of August 24, 2023