xKDR / TSFrames.jl

Timeseries in Julia
MIT License
91 stars 22 forks source link

Add an option to not copy columns when constructing a TSFrame #142

Closed asinghvi17 closed 1 year ago

asinghvi17 commented 1 year ago

Needs tests. Basically, this allows us to construct a TSFrame with negligible overhead.

It's based off asinghvi17:issorted, so once that's merged I'll rebase this.

asinghvi17 commented 1 year ago

Huh! It looks like something changed the sort order for the columns. Ideally we should be using isempty(setdiff(...)) instead of equality here anyway, what do you think @chiraganand?

chiraganand commented 1 year ago

Huh! It looks like something changed the sort order for the columns. Ideally we should be using isempty(setdiff(...)) instead of equality here anyway, what do you think @chiraganand?

This shouldn't be a problem.

PS: Avoid force-pushing because it breaks code coverage and creates problems while merging the branch into main, though it can be done easily by squashing but that loses commit history from the branch.

codecov-commenter commented 1 year ago

Codecov Report

Merging #142 (0f434a5) into main (dd702ea) will decrease coverage by 0.02%. The diff coverage is 96.87%.

@@            Coverage Diff             @@
##             main     #142      +/-   ##
==========================================
- Coverage   91.41%   91.39%   -0.02%     
==========================================
  Files          20       20              
  Lines         431      430       -1     
==========================================
- Hits          394      393       -1     
  Misses         37       37              
Impacted Files Coverage Δ
src/TSFrame.jl 97.95% <96.87%> (ø)
src/utils.jl 86.36% <0.00%> (-0.21%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

asinghvi17 commented 1 year ago

bump @chiraganand - I think this should be mergeable now.