search

xKDR / TSFrames.jl

Timeseries in Julia
MIT License
89 stars 22 forks source link

TSFrames not working in Julia 1.6 #162

Closed enweg closed 3 months ago

enweg commented 1 year ago

I am trying to use TSFrames in a package I am currently developing and noticed that my tests fail in Julia 1.6. It seems like this is due to the following line.:

https://github.com/xKDR/TSFrames.jl/blob/305267dd2bd1ddcc94253e97efe01621e6d0cac5/src/subset.jl#L142

As much as I can see and find online (see this discussion), broadcasting of && is not supported in Julia 1.6. Is there a nice way to fix this, or should TSFrames restate its compatibility to 1.7 and beyond? It currently seems to state 1.6:

https://github.com/xKDR/TSFrames.jl/blob/305267dd2bd1ddcc94253e97efe01621e6d0cac5/Project.toml#L24

chiraganand commented 11 months ago

I think for now we will just keep the compatibility to Julia v1.7. I don't have the time right now to look into this. Will do as soon as I can.