search

xKDR / TSFrames.jl

Timeseries in Julia
MIT License
92 stars 22 forks source link

Adding `MarketData` to doc dependencies. #95

Closed codetalker7 closed 1 year ago

codetalker7 commented 1 year ago

The demo finance documentation was giving an error since MarketData is not in the documentation dependencies. This should fix it. And perhaps for reasons like this we should do strict checking in doc builds.

codecov-commenter commented 1 year ago

Codecov Report

Merging #95 (eb94e59) into main (4ec5129) will increase coverage by 13.08%. The diff coverage is n/a.

@@             Coverage Diff             @@
##             main      #95       +/-   ##
===========================================
+ Coverage   54.41%   67.50%   +13.08%     
===========================================
  Files          19       19               
  Lines         340      360       +20     
===========================================
+ Hits          185      243       +58     
+ Misses        155      117       -38
Impacted Files Coverage Δ
src/utils.jl 32.43% <0.00%> (+10.81%) :arrow_up:
src/getindex.jl 71.68% <0.00%> (+16.68%) :arrow_up:
src/diff.jl 83.33% <0.00%> (+83.33%) :arrow_up:
src/apply.jl 90.47% <0.00%> (+90.47%) :arrow_up:
src/lag.jl 100.00% <0.00%> (+100.00%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

chiraganand commented 1 year ago

The demo finance documentation was giving an error since MarketData is not in the documentation dependencies. This should fix it. And perhaps for reasons like this we should do strict checking in doc builds.

Yes, we do need to enable strict mode. Will you do that? But I guess we will need to replace all doc examples with REPL macro. Maybe this can be pushed to the next release.