search

xLightsSequencer / xLights

xLights is a sequencer for Lights. xLights has usb and E1.31 drivers. You can create sequences in this object oriented program. You can create playlists, schedule them, test your hardware, convert between different sequencers.
GNU General Public License v3.0
549 stars 208 forks source link

Bug: Warp Effect - Treatment drop down #1177

Closed kppankratz closed 6 years ago

kppankratz commented 6 years ago

I noticed that when using certain warp types that every time you click on the effect in the grid, the treatment reverts back to the constant option. Circle Reveal, Banded Swirl, Ripple and Circular Swirl all exhibit this behavior.

Dissolve and Drop reverts back to constant as well in the drop down choices, but the treatment stays at what was selected even though it reads constant.

Running xLights 2018.18 under macOS 10.13.5

keithsw1111 commented 6 years ago

Wasn’t that fixed in .19

kppankratz commented 6 years ago

I compiled the code earlier today and noticed this behavior, then went back to. .18 to make sure it wasn't an issue on my end.

keithsw1111 commented 6 years ago

Then I need a better description of the steps to recreate it.

kppankratz commented 6 years ago

Drop the Warp effect on to the grid.

Select Circle Reveal as the type, and then under the Treatment drop down, select in or out.

Now click the Warp effect on the grid again and you'll notice that the Treatment option has reverted automatically back to the constant option.

The three other warp types I mentioned in the OP exhibit this same behavior. With the Dissolve and Drop types, the treatment reverts back to constant in the drop down menu, but is actually still what you had selected (in or out).

keithsw1111 commented 6 years ago

Fixed for .20 ... there is a sequencing issue with the order in which properties were being loaded ... but we have a standard fix for that.