search

xLightsSequencer / xLights

xLights is a sequencer for Lights. xLights has usb and E1.31 drivers. You can create sequences in this object oriented program. You can create playlists, schedule them, test your hardware, convert between different sequencers.
GNU General Public License v3.0
555 stars 209 forks source link

You can't multiselect 2d or 3d Moving heads in the Layout preview #3841

Open patdelaney opened 1 year ago

patdelaney commented 1 year ago

NOTE: IF YOU DO NOT ATTACH A SEQUENCE THAT DEMONSTRATES YOUR PROBLEM THEN THERE IS A HIGH PROBABILITY YOUR ISSUE WILL JUST BE CLOSED AND NOT INVESTIGATED.

Describe the bug You can't lasso, or multiselect 2d or 3d moving heads from the preview windows. You can select them in the list windows on the left.

To Reproduce Steps to reproduce the behavior: (and/or link to a short video showing the problem with audio track describing what you are doing) add several moving head models try to lasso them or control click and select more than one. It doesn't work

Expected behavior You should be able to

Screenshots If applicable, add screenshots to help explain your problem. image

Versions (please complete the following information):

Additional context Add any other context about the problem here.

Attachments

If you would prefer not to post your sequences publically please say so and be ready to PM them to one of the developers when asked.

AzGilrock commented 1 year ago

Might need a zip file with a sample layout cause lasso selection is still working for me.

AzGilrock commented 1 year ago

Ok I took a look and apparently you meant when the layout is in 2D mode cause its fine in 3D. If you drag select the group of moving heads like in your photo it actually does select them all it just doesn't have a visual indication the extra ones are selected. Try to select them and look at the list on the left and they will all be highlighted as selected and you can then hold down control and they will all move (Just don't click the one with focus to move a group cause control clicking the model with focus removes it from the group).

Normal models turn the pixels yellow in 2D but moving heads don't have any pixels to turn yellow. When a group of models is selected the one with primary focus gets its handles drawn and that's what's going on here. They are all selected but you only see the one with focus have its handles drawn and there are no pixels to turn yellow. You can switch which one has focus by holding control and clicking on another head and the handles will move but all the heads will stay selected.

I'd have to experiment if there's a way to special case highlight a model that doesn't have any pixels. In 3D we draw the white bounding box to indicate selections.

cybercop23 commented 9 months ago

In 3d you can't lasso, you have to select from the list of shift/ctrl select. Didn't realize in 2d you coudln't lasso MH. @AzGilrock @patdelaney is this really worth the effort? So long we know you have to use the list on the left and you can do it.

AzGilrock commented 9 months ago

@cybercop23 You absolutely can lasso select in 3D. Hold down shift and start dragging to select models. We just don't draw the "lasso" box. An enhancement would be to figure out how to draw a 2D dashed box overlay across the 3D space. Also like I said you can lasso select in 2D its just that the moving heads have a tiny boundary box. I had a lot of trouble trying to get DMX head boundary boxes to be the actual size around the object so I believe they are defined as a size of 1. So its not that you can't select it its just that the selection is really small. The models still show as selected in the list when you lasso select them. https://github.com/xLightsSequencer/xLights/assets/2024669/d438fa6b-38fb-4ae5-a3b5-273b1a9da5bf