search

xLightsSequencer / xLights

xLights is a sequencer for Lights. xLights has usb and E1.31 drivers. You can create sequences in this object oriented program. You can create playlists, schedule them, test your hardware, convert between different sequencers.
GNU General Public License v3.0
570 stars 212 forks source link

Verify Frame rate. #4518

Open Strawberry1997 opened 7 months ago

Strawberry1997 commented 7 months ago

I would like Xlights to be able to check the frame rate of a sequence and confirm the number of pixels per port will support. This will make people aware that if they have more than 680 pixels per port and run a sequence at 40 FPS the results may not be what is expected.

Once a sequence is opened and the frame rate is selected I want xlights to scan the ports on the controller to verify the count of pixels will support the frame rate selected. The warning can be put in the check sequence or in the controller tab and highlight the controllers that have issues, if there are too many pixels per port to support the frame rate. There are multiple types of protocols that have different limitations to be considered.

Maybe xlights will scan the controllers and calculate the max frame rate possible and display it on the controller setup tab, this could add more clutter to the controller tab and possible be placed in another area.

Every time I want to check my controllers for max pixels count I go and edit the code to change the pixel limit then open each controller visualizer to check the ports for errors.

MrPierreB commented 7 months ago

Just checking if you know about this feature where it warns you that you cannot do 40fps if you have a certain number of pixels assigned to a port.

40fpsWarning

Strawberry1997 commented 7 months ago

I did not know this feature was available, but doesn't solve the issue I'm having since I want to use 100FPS.

derwin12 commented 7 months ago

So it sounds like we ideally need the warning and max warnings to be dynamic based on fps of the sequence chosen. Seems do-able. Keep in mind these are NOT hard limits - they just mean the controller will likely have to slow down or skip some frames to keep things moving. Things to magically gear way down once you exceed a theoretical limit number.

MrPierreB commented 7 months ago

But does it need to be dynamic based on a sequence. On the controllers tab - if you assign pixels to ports, at that point you will know the limits of each controller regardless of the sequence.

derwin12 commented 7 months ago

That code is already in there. it warms at the frame limit..and errors when you exceed the port limit. sounded like you wanted a warning when you exceed the 100fps limit for example.

On Mon, Apr 22, 2024, 9:20 PM Pierre Beukes @.***> wrote:

But does it need to be dynamic based on a sequence. On the controllers tab

  • if you assign pixels to ports, at that point you will know the limits of each controller regardless of the sequence.

— Reply to this email directly, view it on GitHub https://github.com/xLightsSequencer/xLights/issues/4518#issuecomment-2071222838, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABDNVK6HIQ6MAP5LIEAV5WTY6WZNDAVCNFSM6AAAAABGRZSSVWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZRGIZDEOBTHA . You are receiving this because you commented.Message ID: @.***>

MrPierreB commented 7 months ago

sounded like you wanted a warning when you exceed the 100fps limit for example.

Not me asking for this. I am commenting on this question. :P But as you said, it is already warning you of not being able to run 40fps on controllers tab, it could work out how many fps you can theoretically get, but it isn't needed on a per sequence level was my point. Unless im missing something.

Strawberry1997 commented 7 months ago

It can be a warning per sequence if the frame rate is not possible , but also I would want on the controller tab the max frame rate possible.