search

xLightsSequencer / xLights

xLights is a sequencer for Lights. xLights has usb and E1.31 drivers. You can create sequences in this object oriented program. You can create playlists, schedule them, test your hardware, convert between different sequencers.
GNU General Public License v3.0
542 stars 201 forks source link

Set Center Point seems to have issues with submodels groups #4537

Closed blun23 closed 3 months ago

blun23 commented 4 months ago

NOTE: IF YOU DO NOT ATTACH A SEQUENCE THAT DEMONSTRATES YOUR PROBLEM THEN THERE IS A HIGH PROBABILITY YOUR ISSUE WILL JUST BE CLOSED AND NOT INVESTIGATED.

Describe the bug It seems the newer feature of clicking on layout in 2d and setting center point does not like groups of submodels only. I've noticed it in both Icicle Groups/submodel groups and windows groups/ submodel groups. If you add at least one model to it it works.

To Reproduce Click on a group of submodels, go to layout and right click.

Expected behavior To offer the regular options of normal groups

Screenshots Screenshot 2024-04-30 at 11 02 40 AM

Versions (please complete the following information):

Attachments

If you would prefer not to post your sequences publically please say so and be ready to PM them to one of the developers when asked.

cybercop23 commented 4 months ago

That menu indicates there's nothing selects. Select the group again so the highlight bar is blue and try again.

AzGilrock commented 4 months ago

Yes tell us your exact steps. I think mabye you are selecting the model group in the top left, then you are adding models to it using the lower window, and then you are trying to right-click. The menu makes a call to get the currently selected model group and then checks whether its valid. For some reason there is a mismatch between it showing a group as selected but the program doesn't think a group is selected. Clicking on the group name on the left probably fixes the situation but lets figure out how you got there.

blun23 commented 4 months ago

I'm literally doing nothing different than any other group. I click on the group, click into the layout, right click and set the center point. As a work around last year to not having the center point move, I had created 2 single pixels that I had at the farthest reaches of my layout, so when I added stuff or moved things around the center point stays the same. I'm just going through and setting them so they stay put without those single pixels.
I can show you later tonight on the call Alex.

blun23 commented 4 months ago

It is also happening with my drum stick groups and spinner arm groups, so who knows.

blun23 commented 4 months ago

Okay, now that I've went through a whole bunch, it's seems to be groups of submodels only. Problem lies say in icicles. My GE Icicles I have split into Eaves, Icicles, Tips, etc., so the user can't center the effect themselves with the auto click, I'm going to try to manually do it.

blun23 commented 4 months ago

So they still can be changed the old school manual way, but not using the new center mark technique that Gil put in.

blun23 commented 4 months ago

Changed the title and description to reflect actual issue.

derwin12 commented 4 months ago

Make life easier for us :-) Do a tools->package logs so we can use your layout to debug .. Thanks

AzGilrock commented 4 months ago

So I'm pretty sure its because the IsModelValid() function that is called to check whether its a valid group first iterates through the models and iterates through every submodel of each model but since its only submodels in the group it never iterates through them.

blun23 commented 4 months ago

So I'm pretty sure its because the IsModelValid() function that is called to check whether its a valid group first iterates through the models and iterates through every submodel of each model but since its only submodels in the group it never iterates through them.

This was exactly what I was thinking, but couldn't quite put it into words as eloquently as you did.

blun23 commented 3 months ago

Just noticed today that this is still happening.

derwin12 commented 3 months ago

Just noticed today that this is still happening.

Code is not included yet.

blun23 commented 3 months ago

Just noticed today that this is still happening.

Code is not included yet.

Even using TestFlight?

cybercop23 commented 3 months ago

Yup, even TS. It's a PR that has not yet been merged into the master branch. There are several of them like that. You can see them in the PR tab.

cybercop23 commented 3 months ago

Should be available in the nightly and next version.