xLightsSequencer / xLights

xLights is a sequencer for Lights. xLights has usb and E1.31 drivers. You can create sequences in this object oriented program. You can create playlists, schedule them, test your hardware, convert between different sequencers.
GNU General Public License v3.0
529 stars 196 forks source link

Clean up the indentation of the sequence tab #4408 #4549

Closed derwin12 closed 1 month ago

derwin12 commented 2 months ago

4408 Attempt to clean up the display and properly indent the groups, models, strands and nodes.

image

AzGilrock commented 2 months ago

I can't really tell what's different. And for instance is the "Single Line" model part of the "Group with One Item"? Maybe the name threw me cause its looks like a lot more than one item. The Single Line is indented making it look like its under that group but the group doesn't have the minus box so I'm confused.

AzGilrock commented 2 months ago

I've always thought the layer number looked weird when expanded since the first line is a total and my eyes always think it should look like 1, 2, 3

derwin12 commented 2 months ago

I've always thought the layer number looked weird when expanded since the first line is a total and my eyes always think it should look like 1, 2, 3

Agreed but the first line is [3] total layers .. perhaps flip that to [1] when expanded? would that change confuse people??

derwin12 commented 2 months ago

I can't really tell what's different. And for instance is the "Single Line" model part of the "Group with One Item"? Maybe the name threw me cause its looks like a lot more than one item. The Single Line is indented making it look like its under that group but the group doesn't have the minus box so I'm confused.

[-] is only to collapse layers.. BUT yes this is a bug .. going to fix that up The first single line should be indented from the group but not the models sspinner and the model itself single line. Expanded.. image Collapsed.. image

AzGilrock commented 2 months ago

Hmm....so not sure why we don't use the +/- to expand/collapse groups. Not sure sure about the layer numbering. We should number from the bottom up and say its the render order. :)

cybercop23 commented 2 months ago

Hmm....so not sure why we don't use the +/- to expand/collapse groups. Not sure sure about the layer numbering. We should number from the bottom up and say its the render order. :)

Ohhhh.. I like that.... it will be the truth.... and the 3 on the group/model can stay as it... NICE

deplanche commented 2 months ago

But Layer Blending is based on the current layer being Layer 1 and the layer below that being Layer 2. If they are numbered bottom to top, won't that confuse people even more?

derwin12 commented 2 months ago

Thoughts on this? The numbering ... which way .. this may be something we just don't touch? - as it is built in for canvas mode and such.. Do I bother coding the Empty group to not show the [+] - like who creates empty groups besides me during testing.. What if the closed [3] changes to [1] then [2] then [3] when expanded?? image

AzGilrock commented 2 months ago

Nobody that would get confused blends layers. I'm not even sure what we're talking about layers blend from the bottom to the top inside the model/group layers.

AzGilrock commented 2 months ago

Blend is probably a bad work it doesn't really specify an order. All I can say is think of it like cans of paint. Bottom layer is the first can of spray paint. Next layer up is the second can of spray paint. I don't think the number showing on the left side has anything to do with how layers are handled internally.

derwin12 commented 2 months ago

Here is a new look .. shows 1.2.3 when expanded image

cybercop23 commented 2 months ago

I do really like the idea of showing them in the way they render... from the buttom up. Layer Belnding is done at the effect level, so it should not interfeer with how we display and manage the view itself.

derwin12 commented 2 months ago

Here is another rendition .. Not perfect - groups in groups are not (easily) determined for indenting. Better than before. Notice I moved the group open and close indicator over to the right. The left side is/was required to open/close the layers. You still just double click on it to open, but the triangle gives some clues as to what state you are in. image

Subtle differences from current .10 release.. image