Showing incorrect end channel for MH shadow model

xLightsSequencer / xLights

xLights is a sequencer for Lights. xLights has usb and E1.31 drivers. You can create sequences in this object oriented program. You can create playlists, schedule them, test your hardware, convert between different sequencers.

GNU General Public License v3.0

549 stars 208 forks source link

Showing incorrect end channel for MH shadow model #4557

Closed derwin12 closed 4 months ago

derwin12 commented 5 months ago

The MH Dimmer etc are only 2 ( or 8 or) channels long .. but the layout is showing what appears to be a default of 16 channels.

AzGilrock commented 5 months ago

The layout has always had a refresh issue. Drop another model on the layout and see if it updates.

AzGilrock commented 4 months ago

I can't debug this from just that screenshot. I created a Single Line model with 8 strings, 1 node per string, single color and then mapped each individual start channel to the 4th channel of each moving head. The end channel is going to show the channel 1 past the last channel assigned so you can see its the 5th channel of MovingHead8. That seems normal plus I don't see how this issue is moving head specific seems like it would do this no matter which model type you were trying to shadow.

derwin12 commented 4 months ago

I think in this scenario - ie a shadow model like this .. then the end channel should just be blank. There is no meaningful number you could put there.

cybercop23 commented 4 months ago

We can clen it up like we did for groups.. BUT.... should the start channel also be removed and just leave the @MH:1:1?

derwin12 commented 4 months ago

Seems like a good idea..

cybercop23 commented 4 months ago

So this looks good?

derwin12 commented 4 months ago

I think that makes sense .. also allows one to quickly eyeball all the MH scenarios.

cybercop23 commented 4 months ago

I think that makes sense .. also allows one to quickly eyeball all the MH scenarios.

that and any shadowmodels since they all look alike.