Moving Head Advance - Value Curve on Pan is not respected

[marklancer]

NOTE: IF YOU DO NOT ATTACH A SEQUENCE THAT DEMONSTRATES YOUR PROBLEM THEN THERE IS A HIGH PROBABILITY YOUR ISSUE WILL JUST BE CLOSED AND NOT INVESTIGATED.

Describe the bug A value curve on the Pan slider has no effect

To Reproduce Steps to reproduce the behavior: (and/or link to a short video showing the problem with audio track describing what you are doing)

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Expected behavior Pan should respect the value curve

Screenshots If applicable, add screenshots to help explain your problem.

Versions (please complete the following information): Windows 10 Most recent nightly as of 5/21/24

Additional context Might be related to changes made in commit 15202ed

Attachments

• If associated with a crash please attach/link to a dropbox containing the crash log that was produced
• If it crashed but no crash log was produced please use Tools Menu/Package Logs and attach/link to a dropbox containing the resulting zip file
• If the error relates to rendering an effect or a crash while sequencing please use Tools Menu/Package Sequence and attach/link to a dropbox containing the resulting zip file

If you would prefer not to post your sequences publically please say so and be ready to PM them to one of the developers when asked.

[AzGilrock]

Before I spend any calories on this can someone confirm this? And make sure a fixture number is actually selected because the controls will appear unresponsive if no fixture box is checked.

[cybercop23]

I was watching him on Zoom an can confirm. Works for Tilt and not Pan.

[cybercop23]

If I put VC on both, nothign works.., but if I only put it on Tilt, that still works. So anything that has Pan VC is no bueno.

[AzGilrock]

Yeah Dan's PR didn't break that I did when I was doing the changes to try to only set the pan and tilt channels when they were actually commanded. If you do anything on the position tab you will always have a Pan command but I forgot if its a value curve you get a Pan VC command so I needed to set the flag for both. I just put it on all pan and tilt commands to be safe. So the reason Tilt VC worked was because it was still going through the Pan command section and setting the flag but if it went through Pan VC instead of Pan it wasn't setting the flag. This was all in an effort to only set channels that have been defined like you could have Moving Head effects that only set the Dimmer or only set Color and don't touch the Pan and Tilt channels.

[cybercop23]

Yeah Dan's PR didn't break that I did when I was doing the changes to try to only set the pan and tilt channels when they were actually commanded. If you do anything on the position tab you will always have a Pan command but I forgot if its a value curve you get a Pan VC command so I needed to set the flag for both. I just put it on all pan and tilt commands to be safe. So the reason Tilt VC worked was because it was still going through the Pan command section and setting the flag but if it went through Pan VC instead of Pan it wasn't setting the flag. This was all in an effort to only set channels that have been defined like you could have Moving Head effects that only set the Dimmer or only set Color and don't touch the Pan and Tilt channels.

Need to play more with this.. @marklancer ... we tried multi effects but though they would override like DMX, but Gil already mentions in the discussion that MHE doesn't send out all channels... may be something to play with

[AzGilrock]

If its writing channels it shouldn't let me know. You can see in the effect now there are has_position, has_dimmers, has_color flags so those are the 3 channel types right now and they should not be written unless specifically commanded.