search

xLightsSequencer / xLights

xLights is a sequencer for Lights. xLights has usb and E1.31 drivers. You can create sequences in this object oriented program. You can create playlists, schedule them, test your hardware, convert between different sequencers.
GNU General Public License v3.0
529 stars 196 forks source link

Crash when DMX effect applied to Group #4585

Closed henr5118 closed 1 month ago

henr5118 commented 1 month ago

Describe the bug xLights crashes when a DMX effect is applied to a group of DMX props.

To Reproduce Steps to reproduce the behavior:

  1. Open sequence Test Groups.sxq
  2. Click on the DMX effect on prop Jet - F2
  3. Effect runs as expected.
  4. Press up arrow until the effect is moved to Jets - Right Group
  5. xLights crashes

Expected behavior Expected the DMX effect to be applied the props in the group

Versions (please complete the following information):

Attachments I don't know where to look for a crash log. I'm attaching xLights package logs and package sequence files Test Groups.zip xLightsProblem.zip

Thanks, Dave Henry davejerrihenry@hotmail.com

cybercop23 commented 1 month ago

Well.. I think it is really lying about non-fatal... no other indication in the logs...

2024-05-29 15:45:11,589 5680 log_base [DEBUG] EffectsGrid::MoveSelectedEffectUp moving single effect. 2024-05-29 15:45:11,696 5680 log_base [DEBUG] Job pool new size 4. 2024-05-29 15:45:12,340 5680 log_base [DEBUG] EffectsGrid::MoveSelectedEffectUp moving single effect. 2024-05-29 15:45:12,446 5680 log_base [DEBUG] Job pool new size 4. 2024-05-29 15:45:13,013 5680 log_base [DEBUG] EffectsGrid::MoveSelectedEffectUp moving single effect. 2024-05-29 15:45:13,139 5680 log_base [DEBUG] Job pool new size 4. 2024-05-29 15:45:13,684 5680 log_base [DEBUG] EffectsGrid::MoveSelectedEffectUp moving single effect. 2024-05-29 15:45:13,793 5680 log_base [DEBUG] Job pool new size 4. 2024-05-29 15:45:14,836 5680 log_base [DEBUG] EffectsGrid::MoveSelectedEffectUp moving single effect. 2024-05-29 15:45:14,949 5680 log_base [DEBUG] Job pool new size 4. 2024-05-29 15:45:16,628 5680 log_base [DEBUG] EffectsGrid::MoveSelectedEffectUp moving single effect. 2024-05-29 15:45:16,739 5680 log_base [WARN] Non fatal exception: Exception from main loop.

Doesn't crash on a Mac. I can move the effect to all groups and models without an issue.

cybercop23 commented 1 month ago

Confirmed it fails in Windows but not on a Mac... same "lie"... :) 2024-05-30 09:54:23,037 19700 log_base [WARN] Non fatal exception: Exception from main loop.

computergeek1507 commented 1 month ago

It doesnt crash on master for me anymore.

cybercop23 commented 1 month ago

@henr5118 try the nightly and see if that works for you.

henr5118 commented 1 month ago

@henr5118 try the nightly and see if that works for you.

Will do but headed out of town till Saturday.

cybercop23 commented 1 month ago

Confirmed it works in the nightly. Let us know if any further issues.

AzGilrock commented 1 month ago

I think there is really an issue here because I've gotten lots of reports about crashing when moving effects Up or Down. That is what I keyed on in the description. It had nothing to do with the effect its the moving up and down on the grid that is causing crashes. We are kinda quick to want to close things but can you show me what checkin had an effect on fixing this?

cybercop23 commented 1 month ago

I tested it on both Mac and Windows with his layout/sequence. Crashed on 2024.10 release on Windows and didn't on the nightly. So something did get it working.

henr5118 commented 1 month ago

xLights also crashes if I cut and paste the effect onto a Group that contain DMXGeneral props. It doesn't crash if I copy the effect to a Group that contain DMXFloodLight.