Sort dropdowns for In/Out Transitions and Layer Blending #4587

[AzGilrock]

I can change the comment in the code to be more direct if it helps. I don’t want bullshit blend methods I never use up near the top.

[derwin12]

Easy to add a sort here? Timing tracks on the face effect.

[brett-foy]

Just downloaded last nights build. The sort order on the transitions has changed my entire sequence. Every effect that had Fade (was first on list) is now set to Blend. I don't think this is the desired outcome?

[MrPierreB]

Good spot @brett-foy Although, it is still using fade even though it is showing Blend. Bigger issue is Blend actually doesn't work anymore. Seems T_CHOICE_In_Transition_Type wasn't set in the xml when the very first option is selected from the dropdown, so the fix will mostly likely need be to default set the type to Fade if it is blank in the file, and then going forward also making sure the T_CHOICE_In_Transition_Type is always set. ... or revert the ordering - as fade is the most used transition, going to suck selecting it on almost every effect. :)

Definitely a blocker in the current state. @dkulp

[cybercop23]

Fade should still be the default for any new sequence or when you drop the effect in the sequencer. It's just an option lower on the list. I'll have to take a look this morning, but I remember checking that was the case. I'll look at that TIn/Out too.

Thanks much for testing the nightly and finding and reporting.

[cybercop23]

Fixed.

[MrPierreB]

@cybercop23 Not fully fixed yet. The "Blend" transition is not working. When blend is selected it is fading.

[MrPierreB]

Also, if you select Blend as the transition, then unselect the effect and reselect it, it will change the fade again.

[cybercop23]

How have you tested the latest? Using TestFlight? Or downloaded the build, or built your own?

[cybercop23]

Also, if you select Blend as the transition, then unselect the effect and reselect it, it will change the fade again.

hmmmm.. all others hold, tested a few befoore, just not blend.. Blend is the only one overriden... looking

[cybercop23]

So the issue id with the lack of default TransitionIn/Out values not being available. I can either move the Fade back to the top and have the rest of the list sorted (not my favor) or get all items/regardless of position/default to have values. Will try for this.

[MrPierreB]

How have you tested the latest? Using TestFlight? Or downloaded the build, or built your own?

I got the latest code and built it locally.

[cybercop23]

OMG!!!!!!! WHY!!!!!!

if (Choice_In_Transition_Type->GetSelection() > 0) { s += "T_CHOICE_In_Transition_Type="; s += Choice_In_Transition_Type->GetStringSelection(); s += ","; } So I removed the if and the T_CHOICE_In_Transition_Type now always get written. Also added code for existing ones to convert to Fade and on first save it will have the TT attribute.

[MrPierreB]

OMG!!!!!!! WHY!!!!!!

if (Choice_In_Transition_Type->GetSelection() > 0) { s += "T_CHOICE_In_Transition_Type="; s += Choice_In_Transition_Type->GetStringSelection(); s += ","; } So I removed the if and the T_CHOICE_In_Transition_Type now always get written. Also added code for existing ones to convert to Fade and on first save it will have the TT attribute.

loooooool :P Im guessing the thought was fade will be used so much, it will make the size of the xml (xsq now) more .. thats the only thing i can think of at the moment before the morning coffee kicks in.... anyways, glad you got it sorted :)

[AzGilrock]

All of our effects default values are not written to the XML that’s how we kept them smaller. Look how many characters are being added to every effect all because you guys get anal about sorting that everyone was fine with for 9 years

[dkulp]

All of our effects default values are not written to the XML that’s how we kept them smaller. Look how many characters are being added to every effect all because you guys get anal about sorting that everyone was fine with for 9 years

Yea.. I'm beginning to lean toward reverting the entire thing.....

[AzGilrock]

Seems like there should be a way to still work with default values that aren’t the first item in the list

[AzGilrock]

Without having to write potentially thousands of defaults values to existing sequences when they get updated

[cybercop23]

Well.. the only way is to leave Fade at the top and sort the rest. I think we should still sort the list, but frankly, the XSQ is so small that I don't think 35 characters/fade would be a problem. Nowadays disk is cheap and plentyfull so that shouldn't be a concern.

[computergeek1507]

The change ruined my muscle memory of selecting fade in and out