Sketch Effect - Effects Assist screen issue

[Clyde-L]

Attached below is a screen capture of the Sketch Effect's Effects Assists screen. On the Windows platform, I'm no longer able to zoom all the way out. Also, when resizing the window. You do not see the control buttons at the bottom of the screen.

Edit: There was also a lot of screen flickering when I loaded up an image to draw on. Each time I drug a point around on the effects assist screen it would flash horribly.

Another issue I have is that when packaging up a sequence, the Images used in the Sketch are not being packaged at all. Then, after a user imports a sequence, the Sketch effect looks for the image but can't find it. The next time the sequence is opened, it warns the user they are missing an "asset". Yet, this was supposed to be packaged. Can we just not package or look for sketch image backgrounds? They are completely unnecessary for the sequence to render anyway.

Thank you, Clyde

[derwin12]

What screen resolution & model size ( in case it matters) do you have .. not sure I am seeing the same issue..

[Clyde-L]

I'm running 1920x1080. Applied to a 128x96 matrix prop.

[cybercop23]

This seems to have been introduces by the merge of the MH branch into master. Nightly before that, 865 works as expected, but 866 breaks. Only a few things were added during that one day, most notibly the MH effect, that does have a sketch like panel to draw.

[AzGilrock]

The MH doesn't just have a sketch like panel its using the same Sketch Canvas. I don't remember changing anything that would affect Effect Assist but obviously something happened.

[computergeek1507]

Maybe the onSize addition?

[cybercop23]

Maybe the onSize addition?

yeah.. that's that we're thinking.. Daryl and I were looking at the changes made.. all of the other triggers... should not have been an issue.

[AzGilrock]

Yep probably that. I'm at work and can't login to GitHub due to the stupid 2FA. My phone is like a one minute walk away from my desk so its a pain in the butt to try to authenticate in time.

[AzGilrock]

Can someone test the change I just pushed? I moved the resize logic the Moving head panel needs back into the MovingHeadPanel and removed the OnSize from the SketchCanvasPanel.

[cybercop23]

Yup... works on both Mac and Windows. Thanks for the quick fix.

@Clyde-L you can try the nightly or wait until the next release.

[Clyde-L]

Thank you guys. I'll give it a shot. Is the nightly released already?

[cybercop23]

Not yet... Use this like to get it... https://github.com/xLightsSequencer/xLights/releases/tag/nightly

[Clyde-L]

It seems to work now. I'm able to have the Effects Assist window at a reasonable size. No more scroll bars. Thank you!

However, when there is a background image added to the Sketch Effect, there is a lot of flickering that happens as you draw over top of the image in the Effects Assist window. When no image is attached to the sketch, there is no flickering.

[AzGilrock]

And is that a change in how it used to work?

[Clyde-L]

Yes Gil, the flicker never happened before.

[AzGilrock]

Hmm....all the changes I did for the Moving Head worked just got reversed.

[cybercop23]

I don't see any flickering on the Mac and on Windows I only see it when I'm already zoomed all the way out but keep scrolling the mouse wheel. IDk if that's what you are refering to. Odd that something new would be happening when the change was revertred. If you can please do a screen shot, TTF :) and open a new issue with that and the SVG you're using. This is what I used...

[AzGilrock]

It would be worthwhile to do another check for which version caused this. It may not have been the same one.

[cybercop23]

I can do that once I have a vid and the actual sketch. From what I see in Windows, not an actual issue until you are all zoomed out and keep trying to zoom, but again.. I may not be doing/seeing the same isse has Clyde.

[Clyde-L]

Finally had time to do a short screen capture. I've created a new animation sequence. Went to the sketch effect. Then added an image to the sketch. I started the video at this point. Then you'll see where I start drawing on the Effect's Assist. The screen will flicker. I recorded this on my laptop, but it did the same thing on the desktop. I can not I noticed it on any other release, but acted up when I tried using it on 2024.10.

https://www.dropbox.com/scl/fi/if0gh043fxfnka742kxc7/Recording-Flicker.mp4?rlkey=lq2ntylok40lppq5h63cjjtp4&dl=0

[cybercop23]

The issue strted happening in 2023.23, was fine in 22. Since it is over 6 months, I can't go to the nightlys to pinpoint where it happened, they are expired and I can't get the installer. From there release notes.... I think it is the wxWidgets...

2023.23 Dec 28, 2023 -- enh (dkulp) Convert "New Style" Pinwheel effect to use Meta GPU rendering on MacOS -- enh (scott) Added Scheduling to HinksPix Export Dialog. -- enh (scott) Persist Custom Colors across Color Dialogs. -- enh (dkulp) Update to newer version of wxWidgets that fixes appearance of checkboxes on properties panels -- enh (keith) Bell at end of Batch Render, extra progress displayed during batch render -- enh (keith) Allow user control of maximum Render Cache size -- bug (scott) Fix Import Dialog AutoMapping Aliases to Submodel/Stands. -- bug (scott) Fix Import Dialog Groups Blue turning white. -- bug (scott) Fix 3D Model Export starting at zero. -- bug (scott) Fix DMX Shutter value with On effect and Flood lights. -- bug (keith) Fix crash with parsing JSON with certain UTF-8 characters -- bug (tulzscha) Fix fire effect buffer sizes -- bug (dkulp) Fix some random crashes that occur with various actions on the View Models panel -- bug (dkulp) Fix discovery of Falcon controllers as remotes if needing to use http discovery -- bug (dkulp) Fix potential crash/memory corruption at startup when resolving IP's on background threads -- bug (dkulp) Fix leftover files remaining in tmp directory -- bug (dkulp) Fix some problems writing ZSTD fseq files for layouts with well over 2M channels and complex effects