search

xLightsSequencer / xLights

xLights is a sequencer for Lights. xLights has usb and E1.31 drivers. You can create sequences in this object oriented program. You can create playlists, schedule them, test your hardware, convert between different sequencers.
GNU General Public License v3.0
529 stars 196 forks source link

Effects not working when applied to Groups with DMX props. #4590

Closed henr5118 closed 1 month ago

henr5118 commented 1 month ago

Describe the bug xLights no longer crashes when applying a DMX affect to a group with DMXGeneral props. However, there are still issues with Groups of DMX props.

To Reproduce The Lights props are DMXFloodLight The Jets props are DMXGeneral

Effects applied to Light groups (DMXFloodLight): The ON effect works for White, but not individual colors. The DMX effect does not work correctly. I would think that Channel 1,2,3 would correspond to RGB. The lights are kind of purple if channel 3 is set to 255.

Effect applied to Jets groups (DMXGeneral): The ON effect works only for White. Since there is only one channel that kind of makes sense. The DMX effect does nothing to the props in the group.

Expected behavior Effect applied to groups should work the same as the effect applied to a single prop.

Versions (please complete the following information):

Additional context I also noticed that you can't select a prop in the Layout tab by clicking on the prop. You can only select it from the Models list box.

Attachments Test Groups.zip xLightsProblem.zip

AzGilrock commented 1 month ago

I haven’t opened your files but your expected behavior isn’t going to be true for DMX models. When you drop a regular effect n the model it’s going to find the red channel based on the channel assignment in the model. When you use a DMX effect channel 1 is going to always be the first channel in the model it doesn’t try to go find red. And groups of DMX models will only show effects properly when you set the buffer style to Per Model Default.

henr5118 commented 1 month ago

I've changed the buffer style to Per Model Default and now the effects are working as expected. I'm new to xsLights and trying to use the program to run my animated fountain that uses DMX controllers for the lights and pumps. This is short video of the fountain being driven by a 15 old program this is very tedious to use.

https://github.com/xLightsSequencer/xLights/assets/35005529/4d50d9b8-d4a7-45f8-b6e7-dcc9117ede16

Thanks for the help. You can close this issue. Dave

AzGilrock commented 1 month ago

Nice. I love water props.