search

xLightsSequencer / xLights

xLights is a sequencer for Lights. xLights has usb and E1.31 drivers. You can create sequences in this object oriented program. You can create playlists, schedule them, test your hardware, convert between different sequencers.
GNU General Public License v3.0
530 stars 197 forks source link

.11 Crash #4622

Closed derwin12 closed 3 weeks ago

derwin12 commented 3 weeks ago

While going thru the new features .. it crashed. I havent tracked it down but will see if I can narrow it down. Here are the logs xLightsProblem.zip xLights_dbgrpt-14384-20240618T093839.zip

Autosave? Walking from an exception. [01] ADDR:0x00007ff7eb966c62 HMODULE:0x00007ff7eac30000 0000000000d346a0 xLightsXmlFile.obj ?Save@xLightsXmlFile@@QEAAXAEAVSequenceElements@@@Z@AE2D52 [02] ADDR:0x00007ff7eb9065f0 HMODULE:0x00007ff7eac30000 0000000000cd5e00 xLightsMain.obj ?SaveWorking@xLightsFrame@@QEAAXXZ@A826E0 [03] ADDR:0x00007ff7eb906942 HMODULE:0x00007ff7eac30000 0000000000cd67c0 xLightsMain.obj ?OnTimer_AutoSaveTrigger@xLightsFrame@@QEAAXAEAVwxTimerEvent@@@Z@A82A32

derwin12 commented 3 weeks ago

It seems the .zip file contains the old prior existing _.xbkp file. Perhaps it couldnt write out the contents to .xbkp and crashed?

derwin12 commented 3 weeks ago

Since I was making a bad .11 video at the time .. I have included that for your entertainment :-) Added a couple layers, renamed the layer, dropped the Moving head effect, dropped the off effect .. timer went and it tried to autosave. Shows the exact process I went thru - but I am leaning towards some sort of hiccup writing to the drive? https://github.com/xLightsSequencer/xLights/assets/4643499/ed4840e2-f8a1-44cc-ac20-9be6442b7dd0

cybercop23 commented 3 weeks ago

I can follow your steps using your folder and I get beach-balling on Mac, no crash, but locked up. Will kill it and Dan will get logs.

cybercop23 commented 3 weeks ago

2nd time in a row....

2024-06-18 10:41:17,144 8603012096 log_base [DEBUG] Autosaving backup of sequence. 2024-06-18 10:41:17,145 8603012096 log_base [CRIT] Crashed: Fatal exception occurred.

cybercop23 commented 3 weeks ago

Doesn't crash if you skip renaming /Edit Layer Name a submodel....

derwin12 commented 3 weeks ago

Narrowed it down .. expand a model (Showstopper spinner). Rename the first (only) layer on any submodel. Hit Save. This crashes as effect_layer_node is still null; effect_layer_node->AddAttribute("layerName", layer->GetLayerName());

derwin12 commented 3 weeks ago

This appears to fix it but leave to Dan to code/confirm. image

blun23 commented 3 weeks ago

I can follow your steps using your folder and I get beach-balling on Mac, no crash, but locked up. Will kill it and Dan will get logs.

If I'm having an issue and I kill it, how would I get the logs to send to you guys? Or is it automatic when you force quit

cybercop23 commented 3 weeks ago

I can follow your steps using your folder and I get beach-balling on Mac, no crash, but locked up. Will kill it and Dan will get logs.

If I'm having an issue and I kill it, how would I get the logs to send to you guys? Or is it automatic when you force quit

No need for this one. We have all that we need. Thanks for the offer.

derwin12 commented 3 weeks ago

Dan commited fix.

blun23 commented 3 weeks ago

I can follow your steps using your folder and I get beach-balling on Mac, no crash, but locked up. Will kill it and Dan will get logs.

If I'm having an issue and I kill it, how would I get the logs to send to you guys? Or is it automatic when you force quit

No need for this one. We have all that we need. Thanks for the offer.

I'm fairly good at crashing things when need to.