search

xLightsSequencer / xLights

xLights is a sequencer for Lights. xLights has usb and E1.31 drivers. You can create sequences in this object oriented program. You can create playlists, schedule them, test your hardware, convert between different sequencers.
GNU General Public License v3.0
530 stars 197 forks source link

Error when merging models, no group merging in 2024.11.1 #4625

Closed Clyde-L closed 2 weeks ago

Clyde-L commented 2 weeks ago

We've found a bug in 2024.11.1 when replacing a model with a model. What should happen is, if a model in a layout is attached to groups, and you import the same model with different group; then the groups from the imported model should merge with existing groups. We found this today while trying to update a layout with a new model with different groups than the user already had. The imported model groups were not merged when replacing the model. Please see video link below for full demo.

I'm not sure when this broke. I was able to revert to 2024.2, and process of replacing a model with different groups, and applying it to the existing mode, easily merges the groups from different sequence vendors.

We also found that reverting the layout from 2024.11.1 back to 2024.2, the moving heads would freeze layout opening process and cause xLights to hang-up. We had to create a copy of the layout, delete the moving heads, and then revert to the older version of xLights in order to test this.

Any help to get this fixed will be greatly appreciated.

Thank you for looking, Clyde

https://www.dropbox.com/scl/fi/te4x54vkuiaa6xqrocwgg/Model-Import-Replace.mp4?rlkey=wl8rt4mbd23z4mvtwinznkgl7&dl=0

AzGilrock commented 2 weeks ago

Yeah once the moving head models go through upgrade you can't downgrade them. This isn't unique to moving heads there have been several times a model version has changed and wouldn't work going backwards. Best we could do is detect it and display a dialog and prevent the freeze.

Clyde-L commented 2 weeks ago

Gil that's reasonable. Any idea what happened with group merging?

AzGilrock commented 2 weeks ago

Not offhand we had a ton of changes that went into this build. That’s why quicker release cycle is better it’s easier to narrow down changes that caused an issue

derwin12 commented 2 weeks ago

Same in .10. I will go back a few versions and see if it was any different. Update: Works in .8, broke in .9

derwin12 commented 2 weeks ago

Narrowed down to these .. seems like that 3rd last one is the likely culprit image