xLightsSequencer / xLights

xLights is a sequencer for Lights. xLights has usb and E1.31 drivers. You can create sequences in this object oriented program. You can create playlists, schedule them, test your hardware, convert between different sequencers.
GNU General Public License v3.0
530 stars 197 forks source link

Change Pop up from Abandon Changes to Save Changes #4629

Open Jaa1i opened 2 weeks ago

Jaa1i commented 2 weeks ago

When editing model data, and you press cancel, a prompt asks "Abandon Changes" with the option of No or Yes.

This is vastly different to standard practice with pretty much all computer applications. When attempting to close something without saving, it will ask "Do you want to save changes?" not "Abandon Changes".

I can see someone inadvertently pressing yes, thinking they are saving changes.

Screenshot 2024-06-22 at 23 03 21
AzGilrock commented 2 weeks ago

Isn’t there a different button either ok or save that saves? This would more along the lines of “Are you sure you want to abandon changes?”

Jaa1i commented 2 weeks ago

Yes, if you press OK, it saves. However if you press Cancel, you receive the Abandon Changes pop up. This is not the industry norm. In almost all other applications, if you close a document that you have not saved changes, it doesn't ask you if you wish to Abandon Changes, it asks if you want to save your changes.

AzGilrock commented 2 weeks ago

I’m famous for breaking the industry norm so quoting that doesn’t phase me in the least. I’d actually vote that cancel just freaking cancels the dialog I find it annoying to answer extra questions

computergeek1507 commented 2 weeks ago

The import and Submodel dialog have the same reverse logic questions on close, I thinks it is because everything is upside down and backwards in Australia