xLightsSequencer / xLights

xLights is a sequencer for Lights. xLights has usb and E1.31 drivers. You can create sequences in this object oriented program. You can create playlists, schedule them, test your hardware, convert between different sequencers.
GNU General Public License v3.0
530 stars 197 forks source link

When uploading output to Genius controller pixel count incorrect for unused ports #4639

Open horathgar2000 opened 1 week ago

horathgar2000 commented 1 week ago

Describe the bug On a Genius Long Range Controller with Smart Remotes A and B. If you have no Models on either output it registers as 1 on the controller. If you have a Model on Controller A1 with 50 nodes and nothing on A2 it duplicates 50 on both A1 and A2. The Channels are correct but this may impact the performance "Frames Per Second" of the output of the controller? Also If you have Smart Remote A,B,C and Models on A, C but not B then it duplicates the last model from B to C. Finally DMX has an output of 1 on each port when no models assigned. The controller is reporting over 1000 nodes on a port and therefore would run at 20Fps and not 40Fps as I keep the ports to a maximum of 799 nodes per port. The starting and ending channels are correct for each Model that actually exists in Xlights. Please see attachments

To Reproduce Assign models to a port on a Genius Long Range Controller, Put one on Smart Remote 1A and the second one on 2B. Upload Output to controller and check configuration on controller.

Expected behavior Unused ports I would expect to see a 0 on that port.

Screenshots If applicable, add screenshots to help explain your problem.

Versions (please complete the following information): Windows Versions tested. xLights64_2024_12_nightly-db472d2 xLights64_2024_12 xLights64_2024_11 xLights64_2024_10 xLights64_2023_23

Additional context Screenshot 2024-06-27 193003 Screenshot 2024-06-27 192658 Screenshot 2024-06-27 192800 Screenshot 2024-06-27 193030

Attachments

derwin12 commented 1 week ago

We can duplicate this .. only comes into play on multiple receivers (that we tested)

derwin12 commented 1 week ago

@computergeek1507 Scott would this be from the push or the way the genius receives this port request?

AGFazio commented 1 week ago

Can duplicate on recievers attached to 2023 Genius 16 as well.

derwin12 commented 1 week ago

@computergeek1507 I think you need to zero out the pixel count here (& brightness) image

computergeek1507 commented 1 week ago

Can you send me the layout to test it

horathgar2000 commented 1 week ago

Here is my current layout House-Layout.zip

derwin12 commented 1 week ago

Scott . Andy is in Zoom and can test/duplicate as well.

computergeek1507 commented 1 week ago

Looking at the code it looks like it only happens when Full xLights Control is enabled

AGFazio commented 1 week ago

@computergeek1507 If I turn off full xlights control, I can't upload outputs to the controller. States failed to connect.

computergeek1507 commented 1 week ago

I think CreateVirtualStrings needs to be called with true instead of false.

computergeek1507 commented 1 week ago

are you running firmware 1.1.8 or 1.3.1?

AGFazio commented 1 week ago

I am running 1.3.1

horathgar2000 commented 1 week ago

v1.3.1-2 is what I am currently running. I just tested v1.1.8-0 with similar results, however when there is no prop on Smart receiver A it lists it as DUMMY with a pixel count of Zero.