xLightsSequencer / xLights

xLights is a sequencer for Lights. xLights has usb and E1.31 drivers. You can create sequences in this object oriented program. You can create playlists, schedule them, test your hardware, convert between different sequencers.
GNU General Public License v3.0
549 stars 209 forks source link

Increment/Decrement for shifting pixel numbers in custom model is limited to +/- 10,000 #4645

Closed Poporacer closed 3 months ago

Poporacer commented 3 months ago

Describe the bug If you need to shift pixel numbers on a custom model, the UI input box field is limited to +/- 10,000, you can type a number in there larger than 10,000 and hit OK and it will only shift the numbers by 10,000. If you use the up/down buttons, you can see that it is limited to 10,000

To Reproduce Steps to reproduce the behavior:

  1. Open the Edit Model data for a custom model
  2. Select a range of cells
  3. Right click and select Shift Selected
  4. Enter a value over 10000
  5. Click OK

Expected behavior A clear and concise description of what you expected to happen and why. The shift should shift by the entered number or an error message pop up indicating that the shift won't work as expected.

Screenshots If applicable, add screenshots to help explain your problem. image

Versions (please complete the following information):

Additional context Add any other context about the problem here.

Attachments

If you would prefer not to post your sequences publically please say so and be ready to PM them to one of the developers when asked.

AzGilrock commented 3 months ago

Can't you just shift multiple times? No reason to make it a million to accomodate one crazy person.

Poporacer commented 3 months ago

Yes, that isn't a problem and what I did, I agree that what I am doing is a bit crazy and maybe no one will probably run across this. I thought an error message or note might prevent some confusion in case there are other crazy people! It was just a thought, but it isn't really much of an issue. Thanks