xLightsSequencer / xLights

xLights is a sequencer for Lights. xLights has usb and E1.31 drivers. You can create sequences in this object oriented program. You can create playlists, schedule them, test your hardware, convert between different sequencers.
GNU General Public License v3.0
540 stars 200 forks source link

jukebox loop effect issues #4655

Closed Lanzap closed 1 month ago

Lanzap commented 1 month ago

NOTE: IF YOU DO NOT ATTACH A SEQUENCE THAT DEMONSTRATES YOUR PROBLEM THEN THERE IS A HIGH PROBABILITY YOUR ISSUE WILL JUST BE CLOSED AND NOT INVESTIGATED.

Describe the bug I use the jukebox mode to run specific effects at specific times for a small VBS production on a couple of props. I often need an effect to repeat until I change to another effect, so I use the "loop effect" checkbox. With this, I have encountered two issues on my computers:

  1. At the end of the effect and it's time to restart the effect (in the loop), there is a small disruption that occurs before restarting the effect. It appears that a very brief portion of the next effect in the sequence is played before starting over. If there is no effect immediately following, then it briefly turns off before starting over. I have managed this issue by adding a null pixel or an extra model layer and placing an "off" effect spanning the same time period. Next, I shorten the "off" effect 0.05 - 0.1 milliseconds before the end of the main effect. This seems to work as a hack fix.

  2. Sometimes the loop effect does not work and the rest of the effects afterwards continue to play. I then have to press the same jukebox button again. This is an intermittent problem and occurs sometimes. When it does occur, it usually happens the first time I play an effect from a jukebox button. The second time I click the same jukebox button, it usually loops properly, however, it can still occasionally wander past the loop point.

To Reproduce Steps to reproduce the behavior: The first issue can be reproduced in the provided sequence as follows:

  1. Open the jukebox panel if not already open... a. Select View in the toolbar at the top b. Select Windows c. Click Jukebox
  2. Click #2 in the jukebox window, which is a simple "On" effect for a series of tunnel lights. At the end of the effect, it will briefly turn off before repeating the loop. The jukebox effects are tied to the null pixel. The null pixel "off" effect in the other jukebox effects are slightly shortened to avoid this issue.

The second issue can be reproduced intermittently.

  1. Ensure the jukebox panel is opened (as above).
  2. Select any jukebox effect and wait to see if it continues past the linked effect instead of repeating. Once again, this doesn't always happen, but does happen at least 1/3 of the time.

Expected behavior

  1. For the first issue, I expect a looping effect to restart without briefly playing the next effect and without having to add a null effect with a slightly shortened time frame.

  2. For the second issue, I expect a looping effect to restart consistently without having to constantly monitor the effect to ensure it doesn't move onto the next part of the sequence.

Screenshots I can produce a screen shot if necessary, but I don't think it will reveal very much.

Versions (please complete the following information):

Additional context 2024 arches night 2.zip

Attachments I have attached the sequence file. Please let me know if more information is needed to help resolve this issue. Thanks!