search

xLightsSequencer / xLights

xLights is a sequencer for Lights. xLights has usb and E1.31 drivers. You can create sequences in this object oriented program. You can create playlists, schedule them, test your hardware, convert between different sequencers.
GNU General Public License v3.0
543 stars 201 forks source link

New Moving Head Effect: RGB Moving Head. Selecting a single color appears to send a minimal amout or DMX data to the colors that are not picked. #4694

Open patdelaney opened 1 month ago

patdelaney commented 1 month ago

Version 2024.13 on Windows 10

Describe the bug I have an RGB LED based MH and During testing I think that there is a bug in what DMX data is being sent for Color. When I try to Select Red for example, the visualizer shows the correct color, and on the moving head the Red LED is lit, but there appears to be a small amount of DMX data being sent to the Blue and Green LEDs. This is probably due to the way the color picker is grabbing the value.

How would I select the Red Value (255,0,0) to be sure that there is no other color data being sent?

I have a different style RGB LED head that I can try the same test with and maybe the picures from the head will be more telling.

To Reproduce Configure a RGB LED MH model Go to color tab and click on Red if you look at the LEDs you'll see that the other 2 colors are getting a small amout of data that faintly lights them up. I tested this outside of xLights and just send the data on DMX channel 8 and only the Red led was lit.

Expected behavior Blue should just be Red :-)

Screenshots In this screenshot this is what the moving head thinks it is getting from xLights. It's hard to seem but the Red channel is a lot brighter, but there still is DMX data going to Blue and Green image

xLights setup image

computergeek1507 commented 1 month ago

Can you export the model and attach the file

derwin12 commented 1 month ago

Just to add that I can easily duplicate it with an RGB mh. You can see the there is green and a bit of red when calling for a blue on the color circle (not wheel). image

derwin12 commented 1 month ago

Scott .. I couldnt really improve on this .. the HSV picker will always have some leakage in the RGB values when picking from the rgb wheel and converting to rgb.

computergeek1507 commented 1 month ago

This is the suspect code I think, the border width is offsetting the x,y values causing it to not hit the full value

image

derwin12 commented 1 month ago

Two thoughts here ... what if we added the HSV/RGB boxes where you can enter values? It seems impossible for one to create multiple effects and confidently pull in the same colors each time. Or even between odds n evens etc. Or, remove color panel entirely and use the color picker that every other effect uses?