search

xLightsSequencer / xLights

xLights is a sequencer for Lights. xLights has usb and E1.31 drivers. You can create sequences in this object oriented program. You can create playlists, schedule them, test your hardware, convert between different sequencers.
GNU General Public License v3.0
549 stars 208 forks source link

Falcon PiCap V2 does not showup as selectable #4724

Closed kylegrymonprez closed 1 month ago

kylegrymonprez commented 1 month ago

Describe the bug The new Falcon PiCap V2 cannot be selected in the controllers tab

To Reproduce Steps to reproduce the behavior: (and/or link to a short video showing the problem with audio track describing what you are doing)

  1. Try to add the Falcon PiCap V2 under "Falcon" Vendor Expected behavior A clear and concise description of what you expected to happen and why.

Versions (please complete the following information):

Additional context I looked for the controller definition in the falcon.xcontroller and it is present, however it has a blank "Name" entry. I am unsure if this is intentional or not. This commit by @keithsw1111 adds the payload to the file with the blank name.

I did edit the file locally and add an entry into "Name" and it does then show up, and I was able to push the config to the controller successfully. This could just be a copy/paste error. However, there could be another reason I am unaware of. The fix is trivial it appears.

kylegrymonprez commented 1 month ago

Additionally it seems the PiHat V1 is under the "FPP" vendor. Unsure if this controller should be under FPP or Falcon, but we should probably do it consistently.

derwin12 commented 1 month ago

Appears to be there.. image

derwin12 commented 1 month ago

.. I think "Pi Hat" is a generic entry .. not necessarily just Falcon.

kylegrymonprez commented 1 month ago

Okay.....thats weird. I undid the file edit change and now it's there? I have no idea why......

kylegrymonprez commented 1 month ago

Okay ignore me......fresh install and it's there as well. I couldn't tell you why it wasn't showing up. PEBKAC