search

xLightsSequencer / xLights

xLights is a sequencer for Lights. xLights has usb and E1.31 drivers. You can create sequences in this object oriented program. You can create playlists, schedule them, test your hardware, convert between different sequencers.
GNU General Public License v3.0
554 stars 209 forks source link

Copy & Paste query and also Default Values Query #4748

Open MrPierreB opened 2 months ago

MrPierreB commented 2 months ago

This is 2 queries as I am wanting to find out if this is intended behaviour now as I cant recall it used to being like this.

Query 1 Describe the bug When copying an effect and pasting it after clicking on some other effect, it affects the end result of the paste.

For example: I have a spiral effect with colors set to Green, Yellow and Fuschia. It has a fade in of 0.2 Next to that I have a bars effect with the colors Red and Blue. It has a Fade in of 1 and a Fade out of 1. if you click on the spirals effect and Ctrl C to copy, and then you just click on the bars effect. Now you try to paste the spiral effect you copied anywhere else, the pasted spiral effect will now have 5 colors selected (the 3 from the spiral + 2 from the bars). It will also have a fade in of 0.2 which it had from the initial spirals effect, but will also have a fade out of 1 which it got from the bars.

If the bars effect had a different render style... the pasted effect would also have the render style of the bars effect I am not sure when exactly this started happening - but ideally what I copied should be pasted as it was copied, not changed depending if i clicked on another effect.

You can imagine ona longer song when you copy an effect and want to ensure you put it at the correct location, so you might click on an effect to ensure that is where you want to paste it.

You can use this zip to click and copy the spirals effect, click on the bars, and then after that paste on the timeline. CopyPasteQuery.zip

CopyPasteQuery

Query 2 Describe the bug Dragging an effect from the toolbar not having default values. When you have a spirals effect on the timeline and that is the last effect you clicked on, if you drag a spirals effect onto the timeline from the toolbar, it will have the same values set and not the effect's default values. I will have to go back a couple of years now but I was under the impression that if you dragged an effect onto the timeline from the toolbar (1) it would have default values and if you wanted it to have the same values as another spirals effect, you would drag it from the icon on that spiral effects "Effect settings" window (2).

CopyPasteQuery1

So an example would be maybe a newbie puts an spirals on the timeline, they maybe click on Thickness and sets some crazy value curve. They just delete the effect as they dont like it, they drag on a new spirals effect from the toolbar , only for it to keeep that value curve (as the spiral effect they deleted was the last one they clicked on). Not the best example, but it demonstrates my point.

derwin12 commented 2 months ago

Query 2 - checked back to the 2019.1 and it is the same experience. If you continually drag the same effect from the toolbar it does NOT reset to default. If you drag another item then go back .. it will be the default. I don't see this changing at this point.

MrPierreB commented 2 months ago

Query 2 - checked back to the 2019.1 and it is the same experience. If you continually drag the same effect from the toolbar it does NOT reset to default. If you drag another item then go back .. it will be the default. I don't see this changing at this point.

All good, for some reason I had that behaviour wrong in my head - just thought I would bring it up, the Query 1 is the one that is a bit more annoying :)

keithsw1111 commented 2 months ago

Query 2 - checked back to the 2019.1 and it is the same experience. If you continually drag the same effect from the toolbar it does NOT reset to default. If you drag another item then go back .. it will be the default. I don't see this changing at this point.

That is the intended behaviour.

derwin12 commented 2 months ago

I went back two years .. same experience. You are copy and pasting the effect and colors not the blending, settings, etc. You can see this by pasting into notepad. I see that the colors checked are included in the paste .. so it should be possible to ensure that is correct. Let me check into that.

Update: too risky a change for me - looks like we would have to have mPalleteMap capture all the states of the colors.