xLightsSequencer / xLights

xLights is a sequencer for Lights. xLights has usb and E1.31 drivers. You can create sequences in this object oriented program. You can create playlists, schedule them, test your hardware, convert between different sequencers.
GNU General Public License v3.0
556 stars 209 forks source link

Submodels don't accurately match pixels defined in custom model when pixels are not in sequence in custom model's "model data" #4945

Open tomhammond opened 1 week ago

tomhammond commented 1 week ago

Describe the bug I attached seeds to a wireframe. To make the seeds jump from area to area, I choose to not light up seeds between jump points. For example, seeds 1-10 are active, there is a gap of three unused seeds, then seeds 14-24 are active.

In the attached example, in the custom model's model data, I define pixels 1-10 and 14-24, leaving out pixels 11-13. This works as expected.

When I create a submodel, it shows all pixels from 1-24 even though 11-13 are not defined in the custom model's model data.

If you look at my layout, look at the left boot in the "Santa" custom model. It starts with pixels 1-10, then jumps to 19-62, then jumps to 75-85. Leaving out pixels 11-19 and 63-74 is intentional; I don't want them to light-up on the string.

But when you go into submodels and create a new submodel, it shows all pixels 1-85 and the pixels are not in the correct locations as compared to the original model data (they are shifted).

Expected behavior The bug: The submodel should not display pixels that have not been defined in the custom model's model data.

Screenshots model data (good) submodel (bad)

Versions (please complete the following information): Windows 11 xLights 2024.15

Attachments show xml files.zip

Thank you! Tom Hammond

computergeek1507 commented 4 hours ago

the submodel number is actually the index of the Node Vector, when you type "11" it is really node 14. Its not good practice to skip nodes.