search

xLightsSequencer / xLights

xLights is a sequencer for Lights. xLights has usb and E1.31 drivers. You can create sequences in this object oriented program. You can create playlists, schedule them, test your hardware, convert between different sequencers.
GNU General Public License v3.0
556 stars 209 forks source link

Papercut: Property grid values don't get confirmed if you select another object #4961

Open degracode opened 5 hours ago

degracode commented 5 hours ago

Describe the bug For me this is a very common papercut - when editing a value in a property grid - significantly, a controller in the Controllers tab, or model in the Layout tab), I will instinctively type in the new value, then found that it's been lost because I didn't explicitly confirm the edit, eg with Enter, or selecting another property. It usually happens because I've clicked on another controller or model.

To Reproduce Steps to reproduce the behavior: (and/or link to a short video showing the problem with audio track describing what you are doing)

  1. Add two controllers to the Controller tab
  2. Click on the first controller
  3. In the property grid, start typing in a new name
  4. Use the mouse to select the second controller Notice that the name change was cancelled.

I've had the same papercut occur with controllers, models, 3d objects and the custom model dialog.

Expected behavior Property grids should assume that you meant to make the edit you had typed in, and accept it on defocus.

Versions (please complete the following information):

derwin12 commented 4 hours ago

That is just a "feature" of wxwidgets. Nothing we can do to change that. Always tab out or press Enter to confirm the change.