xMAnton / ADPassword

Change Active Directory passwords from the Zimbra web client
Other
3 stars 15 forks source link

Support? Fork? #5

Open barrydegraaff opened 8 years ago

barrydegraaff commented 8 years ago

@xMAnton Hello and thanks for your work on ADPassword, do you still support this work?

If you like, we can take it under our umbrella, and fix bugs and issues in our community repo at https://github.com/Zimbra-Community

If you like, you can transfer the repo there so we can all work on it together.

If not, we can also fork and send you pull requests, or if you are not interested at all, we can make a permanent fork (and track issues for our fork)

Please let me know, thanks a lot!

Barry

xMAnton commented 8 years ago

Hello @barrydegraaff

Thanks for your interest on ADPassword.

Well, last time I've used Zimbra was a couple of years ago, therefore no serious support for ADPassword lately. Actually, I'd like to deploy Zimbra in my organization. It's just a question of time.

I believe that moving the repo it's better and smarter. So ok, just tell me what to do and I'll do it.

Authorship kept, right?

Antonio.

barrydegraaff commented 8 years ago

Great, and good to hear you still want to deploy Zimbra.

I just invited you to join Zimbra-Community Github, you should be able to log on to xMAnton/ADPassword repository, click settings, scroll down to Danger Zone and click Transfer Repository.

Under New owner’s GitHub username or organization name type Zimbra-Community.

In the new repo, you will get full access read/write and you stay they author and copyright holder of your work of course.

Also, I'd like to add some more details to the install Readme, can you provide a build how-to?

And some other added some patches for Zimbra 8.6, I looked at the diff, and we should be able to merge those, so the ADPassword works on 8.6 as well (I think it now does not).

https://github.com/Zimbra-Community/vnc-ad-password-change/tree/master/src/ext-ad-password/src/it/iknowconsulting/adpassword

Thanks again, please let me know if you have any issues with the above.

Best regards, Barry

xMAnton commented 8 years ago

Maybe something is wrong, because:

I'll be back at work next week (I am on vacation right now) and a brand new computer is waiting for me. Once installed the essentials, I'd like to apply some very little change to the code (just the package hierarchy) before the transfer.

I hope it's not a problem if we postpone to the first week of April. Do you agree?

Let me know, Antonio

xMAnton commented 8 years ago

Ops, sorry. My bad!

I have seen the invitation email now, so forget the issues. Membership done.

barrydegraaff commented 8 years ago

Next week is fine!

barrydegraaff commented 8 years ago

Hello Antonio, It turns out your extension still works for Zimbra 8.6, it just needed a little more documentation, can you merge my documentation? https://github.com/xMAnton/ADPassword/pull/6 Thanks a lot, Barry

Date: Wed, 30 Mar 2016 23:54:54 -0700 From: notifications@github.com To: ADPassword@noreply.github.com CC: info@barrydegraaff.tk Subject: Re: [xMAnton/ADPassword] Support? Fork? (#5)

Ops, sorry. My bad!

I have seen the invitation email now, so forget the issues. Membership done.

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub

barrydegraaff commented 8 years ago

Whoops moving on to https://github.com/xMAnton/ADPassword/pull/7

barrydegraaff commented 8 years ago

https://github.com/xMAnton/ADPassword/pull/8

Sorry for spamming

barrydegraaff commented 8 years ago

https://github.com/xMAnton/ADPassword/pull/9

Took care of case vs CASE

barrydegraaff commented 8 years ago

https://github.com/xMAnton/ADPassword/pull/10

Add debug info

barrydegraaff commented 8 years ago

The last PR for now I hope: https://github.com/xMAnton/ADPassword/pull/15